oss/luanti
oss/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-07-02 16:38:41 +00:00
Code Wiki Activity

Improve fs::PathStartsWith to handle empty strings (#14877)

Browse source 
`""` does not refer to a proper path, and `fs::PathStartsWith(path, "")` should just return `false`. This is also the case in libraries in other languages where I looked, seems to be common.

The new behavior:
* check early, if `prefix` is empty - return if path is empty or not,
* no special processing for when `path` is empty, the function meets characters in `prefix` and returns false anyway.
This commit is contained in:
asrelo 2024-08-11 21:19:14 +03:00 • committed by GitHub
parent 5b19d315b3
commit cfa9c83d33
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 23 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

23
src/unittest/test_filesys.cpp
View file

@ -113,6 +113,7 @@ void TestFileSys::testPathStartsWith()
};
/*
expected fs::PathStartsWith results
(row for every path, column for every prefix)
0 = returns false
1 = returns true
2 = returns false on windows, true elsewhere
@ -122,17 +123,17 @@ void TestFileSys::testPathStartsWith()
*/
int expected_results[numpaths][numpaths] = {
{1,2,0,0,0,0,0,0,0,0,0,0},
{1,1,0,0,0,0,0,0,0,0,0,0},
{1,1,1,0,0,0,0,0,0,0,0,0},
{1,1,1,1,0,0,0,0,0,0,0,0},
{1,1,0,0,1,0,0,0,0,0,0,0},
{1,1,0,0,0,1,0,0,1,1,0,0},
{1,1,0,0,0,0,1,4,1,0,0,0},
{1,1,0,0,0,0,4,1,4,0,0,0},
{1,1,0,0,0,0,0,0,1,0,0,0},
{1,1,0,0,0,0,0,0,1,1,0,0},
{1,1,0,0,0,0,0,0,0,0,1,0},
{1,1,0,0,0,0,0,0,0,0,0,1},
{0,1,0,0,0,0,0,0,0,0,0,0},
{0,1,1,0,0,0,0,0,0,0,0,0},
{0,1,1,1,0,0,0,0,0,0,0,0},
{0,1,0,0,1,0,0,0,0,0,0,0},
{0,1,0,0,0,1,0,0,1,1,0,0},
{0,1,0,0,0,0,1,4,1,0,0,0},
{0,1,0,0,0,0,4,1,4,0,0,0},
{0,1,0,0,0,0,0,0,1,0,0,0},
{0,1,0,0,0,0,0,0,1,1,0,0},
{0,1,0,0,0,0,0,0,0,0,1,0},
{0,1,0,0,0,0,0,0,0,0,0,1},
};
for (int i = 0; i < numpaths; i++)