oss/luanti
oss/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-08-26 18:21:04 +00:00
Code Wiki Activity

Error when string.split is given empty separator (#13132)

Browse source
This commit is contained in:
Jude Melton-Houghton 2023-01-10 09:25:48 -05:00 • committed by GitHub
parent a3177b89d8
commit ab1fe80150
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
builtin/common/misc_helpers.lua
View file

@ -170,6 +170,9 @@ end
--------------------------------------------------------------------------------
function string.split(str, delim, include_empty, max_splits, sep_is_pattern)
delim = delim or ","
if delim == "" then
error("string.split separator is empty", 2)
end
max_splits = max_splits or -2
local items = {}
local pos, len = 1, #str

6
builtin/common/tests/misc_helpers_spec.lua
View file

@ -38,6 +38,12 @@ describe("string", function()
assert.same({ "one", "two" }, string.split("one,two", ",", false, -1, true))
assert.same({ "one", "two", "three" }, string.split("one2two3three", "%d", false, -1, true))
end)
it("rejects empty separator", function()
assert.has.errors(function()
string.split("", "")
end)
end)
end)
end)