oss/luanti
oss/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-06-27 16:36:03 +00:00
Code Wiki Activity

Performance Improvement: Use a cache which caches result for getFacePositions.

Browse source 
This greatly reduce the number of std::list generated by caching the result, which is always constant for each radius selected.
In the callgrind map, you will see original:
  * 3.3M calls to std::list for 9700 calls to getFacePositions
In the modified version, you will see:
  * 3.3K calls to std::list for 6900 call to getFacePositions
Callgrind map is here: #2321

it's a huge performance improvement to l_find_node_near
This commit is contained in:
Loic Blot 2015-02-15 17:30:38 +01:00
parent ed04e8e9e4
commit 7c8793cbea
4 changed files with 81 additions and 68 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/script/lua_api/l_env.cpp
View file

@ -530,9 +530,8 @@ int ModApiEnvMod::l_find_node_near(lua_State *L)
}
for(int d=1; d<=radius; d++){
std::list<v3s16> list;
getFacePositions(list, d);
for(std::list<v3s16>::iterator i = list.begin();
std::vector<v3s16> list = FacePositionCache::getFacePositions(d);
for(std::vector<v3s16>::iterator i = list.begin();
i != list.end(); ++i){
v3s16 p = pos + (*i);
content_t c = env->getMap().getNodeNoEx(p).getContent();