oss/luanti
oss/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-06-27 16:36:03 +00:00
Code Wiki Activity

Noise: Prevent unittest crash caused by division by zero

Browse source
This commit is contained in:
SmallJoker 2017-07-29 19:01:14 +02:00
parent e9d7005799
commit 765fd9a0bc
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/noise.cpp
View file

@ -130,7 +130,9 @@ s32 PcgRandom::range(s32 min, s32 max)
if (max < min) if (max < min)
throw PrngException("Invalid range (max < min)"); throw PrngException("Invalid range (max < min)");
u32 bound = max - min + 1; // We have to cast to s64 because otherwise this could overflow,
// and signed overflow is undefined behavior.
u32 bound = (s64)max - (s64)min + 1;
return range(bound) + min; return range(bound) + min;
} }