oss/luanti
oss/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-08-06 17:41:04 +00:00
Code Wiki Activity

Fix undefined behaviors (#14365)

Browse source 
* Initialize member `floats` in ContentFeatures

* Do not assign big double to u32

* Do not assign negative floating point number to unsigned integer
This commit is contained in:
fuzun 2024-02-15 11:05:42 +01:00 • committed by GitHub
parent 3cac17d23e
commit 6cbb9193ea
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/mapgen/mg_biome.cpp
View file

@ -297,7 +297,11 @@ Biome *BiomeGenOriginal::calcBiomeFromNoise(float heat, float humidity, v3s16 po
// Carefully tune pseudorandom seed variation to avoid single node dither
// and create larger scale blending patterns similar to horizontal biome
// blend.
const u64 seed = pos.Y + (heat + humidity) * 0.9f;
// The calculation can be a negative floating point number, which is an
// undefined behavior if assigned to unsigned integer. Cast the result
// into signed integer before it is casted into unsigned integer to
// eliminate the undefined behavior.
const u64 seed = static_cast<s64>(pos.Y + (heat + humidity) * 0.9f);
PcgRandom rng(seed);
if (biome_closest_blend && dist_min_blend <= dist_min &&