oss/luanti
oss/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-07-27 17:28:41 +00:00
Code Wiki Activity

Fix meaning of VoxelArea::hasEmptyExtent()

Browse source
This commit is contained in:
sfan5 2024-12-06 21:03:52 +01:00
parent 8957739cdf
commit 67126cbd1b
3 changed files with 6 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/voxel.h
View file

@ -114,11 +114,9 @@ public:
return m_cache_extent;
}
/// @note `getVolume() == 0` and `getEmptyExtent()` are not equivalent.
bool hasEmptyExtent() const
{
// FIXME: shouldn't this actually be a component-wise check?
return m_cache_extent == v3s32(0,0,0);
return !m_cache_extent.X || !m_cache_extent.Y || !m_cache_extent.Z;
}
s32 getVolume() const
@ -207,7 +205,7 @@ public:
if(a.hasEmptyExtent())
{
VoxelArea b = *this;
if (b.getVolume() != 0)
if (!b.hasEmptyExtent())
result.push_back(b);
return;
}
@ -216,7 +214,7 @@ public:
const auto &take = [&result] (v3s16 min, v3s16 max) {
VoxelArea b(min, max);
if (b.getVolume() != 0)
if (!b.hasEmptyExtent())
result.push_back(b);
};