From 6431ef7324a36cc0752de30b9e96eb2dadda1b58 Mon Sep 17 00:00:00 2001 From: Erich Schubert Date: Mon, 14 Oct 2024 22:09:01 +0200 Subject: [PATCH] Trivial improvement to `get_item_group` (#15260) One hash table lookup is enough, and this is even easier for the JIT to inline, optimize, etc. --- builtin/game/misc_s.lua | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/builtin/game/misc_s.lua b/builtin/game/misc_s.lua index ab15b230e..440e52d81 100644 --- a/builtin/game/misc_s.lua +++ b/builtin/game/misc_s.lua @@ -25,11 +25,8 @@ end function core.get_item_group(name, group) - if not core.registered_items[name] or not - core.registered_items[name].groups[group] then - return 0 - end - return core.registered_items[name].groups[group] + local def = core.registered_items[name] + return def and def.groups[group] or 0 end