mirror of
https://github.com/luanti-org/luanti.git
synced 2025-06-27 16:36:03 +00:00
ObjDefManager: Set replacement object's handle info after calling set()
Make gamedef optional when constructing an ObjDefManager Add note about object ownership
This commit is contained in:
parent
5704fb36d2
commit
5b237b4d94
2 changed files with 15 additions and 3 deletions
|
@ -434,7 +434,7 @@ void GenerateNotifier::getEvents(
|
|||
ObjDefManager::ObjDefManager(IGameDef *gamedef, ObjDefType type)
|
||||
{
|
||||
m_objtype = type;
|
||||
m_ndef = gamedef->getNodeDefManager();
|
||||
m_ndef = gamedef ? gamedef->getNodeDefManager() : NULL;
|
||||
}
|
||||
|
||||
|
||||
|
@ -471,7 +471,16 @@ ObjDef *ObjDefManager::get(ObjDefHandle handle) const
|
|||
ObjDef *ObjDefManager::set(ObjDefHandle handle, ObjDef *obj)
|
||||
{
|
||||
u32 index = validateHandle(handle);
|
||||
return (index != OBJDEF_INVALID_INDEX) ? setRaw(index, obj) : NULL;
|
||||
if (index == OBJDEF_INVALID_INDEX)
|
||||
return NULL;
|
||||
|
||||
ObjDef *oldobj = setRaw(index, obj);
|
||||
|
||||
obj->uid = oldobj->uid;
|
||||
obj->index = oldobj->index;
|
||||
obj->handle = oldobj->handle;
|
||||
|
||||
return oldobj;
|
||||
}
|
||||
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue