oss/luanti
oss/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-06-27 16:36:03 +00:00
Code Wiki Activity

refacto: RenderingEngine::get_scene_manager() is now not callable from singleton

Browse source 
This permits to make evidence that we have some bad object passing on various code parts. I fixed majority of them to reduce the scope of passed objects

Unfortunately, for some edge cases i should have to expose ISceneManager from client, this should be fixed in the future when our POO will be cleaner client side (we have a mix of rendering and processing in majority of the client objects, it works but it's not clean)
This commit is contained in:
Loic Blot 2021-04-29 09:40:56 +02:00 • committed by Loïc Blot
parent ccdd886e27
commit 5a02c376ea
11 changed files with 28 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/client/renderingengine.h
View file

@ -79,10 +79,9 @@ public:
return s_singleton->m_device->getVideoDriver();
}
static scene::ISceneManager *get_scene_manager()
scene::ISceneManager *get_scene_manager()
{
sanity_check(s_singleton && s_singleton->m_device);
return s_singleton->m_device->getSceneManager();
return m_device->getSceneManager();
}
static irr::IrrlichtDevice *get_raw_device()