oss/luanti
oss/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-06-27 16:36:03 +00:00
Code Wiki Activity

Add minetest.bulk_set_node call + optimize Environment::set_node call (#6958)

Browse source 
* Add minetest.bulk_set_node call + experimental mod unittest

* Optimize set_node function to prevent triple lookup on contentfeatures

Do only one lookup for old, and try to merge old and new lookup if node is same than previous node

* Add benchmark function + optimize vector population to have real results
This commit is contained in:
Loïc Blot 2018-01-30 00:30:02 +01:00 • committed by GitHub
parent 3b4df956b1
commit 584d00a01c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 124 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/serverenvironment.cpp
View file

@ -917,8 +917,10 @@ bool ServerEnvironment::setNode(v3s16 p, const MapNode &n)
INodeDefManager *ndef = m_server->ndef();
MapNode n_old = m_map->getNodeNoEx(p);
const ContentFeatures &cf_old = ndef->get(n_old);
// Call destructor
if (ndef->get(n_old).has_on_destruct)
if (cf_old.has_on_destruct)
m_script->node_on_destruct(p, n_old);
// Replace node
@ -929,11 +931,15 @@ bool ServerEnvironment::setNode(v3s16 p, const MapNode &n)
m_map->updateVManip(p);
// Call post-destructor
if (ndef->get(n_old).has_after_destruct)
if (cf_old.has_after_destruct)
m_script->node_after_destruct(p, n_old);
// Retrieve node content features
// if new node is same as old, reuse old definition to prevent a lookup
const ContentFeatures &cf_new = n_old == n ? cf_old : ndef->get(n);
// Call constructor
if (ndef->get(n).has_on_construct)
if (cf_new.has_on_construct)
m_script->node_on_construct(p, n);
return true;