oss/luanti
oss/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-08-16 18:01:40 +00:00
Code Wiki Activity

Revert a const ref on update texture

Browse source 
if mod is a reference to a class member a variable swap breaks.
We should find a way to keep this const ref if possible.
Added a comment about this in header
This commit is contained in:
Loic Blot 2017-04-22 00:36:59 +02:00
parent 113c85a66a
commit 4f4e2e3e83
No known key found for this signature in database
GPG key ID: EFAA458E8C153987
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/content_cao.cpp
View file

@ -1313,7 +1313,7 @@ void GenericCAO::updateTexturePos()
}
}
void GenericCAO::updateTextures(const std::string &mod)
void GenericCAO::updateTextures(std::string mod)
{
ITextureSource *tsrc = m_client->tsrc();

4
src/content_cao.h
View file

@ -200,7 +200,9 @@ public:
void updateTexturePos();
void updateTextures(const std::string &mod);
// std::string copy is mandatory as mod can be a class member and there is a swap
// on those class members
void updateTextures(std::string mod);
void updateAnimation();