mirror of
https://github.com/luanti-org/luanti.git
synced 2025-06-27 16:36:03 +00:00
Add NodeResolver documentation
Set content to fallback on AddNode failure Consider node list requests with no results as failed
This commit is contained in:
parent
bc28ca0636
commit
4a3592ff9a
2 changed files with 97 additions and 4 deletions
|
@ -1282,11 +1282,12 @@ int NodeResolver::addNode(std::string n_wanted, std::string n_alt,
|
|||
if (m_ndef->getId(n_wanted, *content))
|
||||
return NR_STATUS_SUCCESS;
|
||||
|
||||
if (n_alt == "")
|
||||
if (n_alt == "" || !m_ndef->getId(n_alt, *content)) {
|
||||
*content = c_fallback;
|
||||
return NR_STATUS_FAILURE;
|
||||
}
|
||||
|
||||
return m_ndef->getId(n_alt, *content) ?
|
||||
NR_STATUS_SUCCESS : NR_STATUS_FAILURE;
|
||||
return NR_STATUS_SUCCESS;
|
||||
} else {
|
||||
NodeResolveInfo *nfi = new NodeResolveInfo;
|
||||
nfi->n_wanted = n_wanted;
|
||||
|
@ -1378,7 +1379,7 @@ int NodeResolver::resolveNodes()
|
|||
"resolve '" << nri->n_wanted;
|
||||
if (nri->n_alt != "")
|
||||
errorstream << "' and '" << nri->n_alt;
|
||||
errorstream << "' to a content ID" << std::endl;
|
||||
errorstream << "'" << std::endl;
|
||||
}
|
||||
|
||||
delete nri;
|
||||
|
@ -1399,6 +1400,12 @@ int NodeResolver::resolveNodes()
|
|||
m_ndef->getIds(name, idset);
|
||||
for (it = idset.begin(); it != idset.end(); ++it)
|
||||
output->push_back(*it);
|
||||
|
||||
if (idset.size() == 0) {
|
||||
num_failed++;
|
||||
errorstream << "NodeResolver::resolveNodes(): Failed to "
|
||||
"resolve '" << name << "'" << std::endl;
|
||||
}
|
||||
}
|
||||
|
||||
//// Mark node registration as complete so future resolve
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue