oss/luanti
oss/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-06-27 16:36:03 +00:00
Code Wiki Activity

Abort when trying to set a not registered node (#7011)

Browse source 
I removed the MapNode constructor which takes a nodename and gives the node's id or CONTENT_IGNORE
The code which used this constructor (two places) now handles the situation of not registered nodes correctly:
* minetest.set_node and similar functions make minetest crash when a not registered node is passed
* reverting a node with rollback aborts if the node is not registered
This commit is contained in:
HybridDog 2019-03-07 08:31:25 +01:00 • committed by Loïc Blot
parent 3066d76e33
commit 431d8a9b83
4 changed files with 13 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/mapnode.cpp
View file

@ -44,18 +44,6 @@ static const u8 rot_to_wallmounted[] = {
MapNode
*/
// Create directly from a nodename
// If name is unknown, sets CONTENT_IGNORE
MapNode::MapNode(const NodeDefManager *ndef, const std::string &name,
u8 a_param1, u8 a_param2)
{
content_t id = CONTENT_IGNORE;
ndef->getId(name, id);
param0 = id;
param1 = a_param1;
param2 = a_param2;
}
void MapNode::getColor(const ContentFeatures &f, video::SColor *color) const
{
if (f.palette) {