oss/luanti
oss/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-06-27 16:36:03 +00:00
Code Wiki Activity

Settings: Prevent mutex deadlock in remove() (#7803)

Browse source
This commit is contained in:
SmallJoker 2019-09-18 18:48:23 +02:00
parent 94a5df795c
commit 4271889ef8
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/settings.cpp
View file

@ -908,17 +908,20 @@ bool Settings::setNoiseParams(const std::string &name,
bool Settings::remove(const std::string &name) bool Settings::remove(const std::string &name)
{ {
MutexAutoLock lock(m_mutex); // Lock as short as possible, unlock before doCallbacks()
m_mutex.lock();
SettingEntries::iterator it = m_settings.find(name); SettingEntries::iterator it = m_settings.find(name);
if (it != m_settings.end()) { if (it != m_settings.end()) {
delete it->second.group; delete it->second.group;
m_settings.erase(it); m_settings.erase(it);
m_mutex.unlock();
doCallbacks(name); doCallbacks(name);
return true; return true;
} }
m_mutex.unlock();
return false; return false;
} }