oss/luanti
oss/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-06-27 16:36:03 +00:00
Code Wiki Activity

TileLayer: use shared_ptr for FrameSpec vector (#6171)

Browse source 
* TileLayer: use shared_ptr for vector framespec
This reduce memory copy of TileLayer from (4 to 16) * FrameSpec where FrameSpec = (sizeof(int) + 3 * sizeof(ptr)) to int + sizeof(ptr)

Callgrind difference

Before: https://lut.im/RGkiJqQb8T/LeQIEXpAuRzfl7gd.png
After: https://lut.im/bcqmwee1xu/cTwtptY5tRuS9lp0.png

* Fix one push_back to use vector::emplace_back & optimize inclusions
This commit is contained in:
Loïc Blot 2017-07-26 20:12:48 +02:00 • committed by GitHub
parent 9a17b65f26
commit 3e50850260
5 changed files with 14 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/nodedef.cpp
View file

@ -637,7 +637,10 @@ void ContentFeatures::fillTileAttribs(ITextureSource *tsrc, TileLayer *tile,
tile->material_flags &= ~MATERIAL_FLAG_ANIMATION;
} else {
std::ostringstream os(std::ios::binary);
tile->frames.resize(frame_count);
if (!tile->frames) {
tile->frames = std::make_shared<std::vector<FrameSpec>>();
}
tile->frames->resize(frame_count);
for (int i = 0; i < frame_count; i++) {
@ -652,7 +655,7 @@ void ContentFeatures::fillTileAttribs(ITextureSource *tsrc, TileLayer *tile,
if (tile->normal_texture)
frame.normal_texture = tsrc->getNormalTexture(os.str());
frame.flags_texture = tile->flags_texture;
tile->frames[i] = frame;
(*tile->frames)[i] = frame;
}
}
}