oss/luanti
oss/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-09-05 18:41:05 +00:00
Code Wiki Activity

Fix various performance issues reported by cppcheck (#5628)

Browse source 
* Also remove 1 non declared but defined functions
This commit is contained in:
Loïc Blot 2017-04-21 10:06:08 +02:00 • committed by GitHub
parent de5ecc9fa3
commit 370354cc87
8 changed files with 57 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/guiEngine.cpp
View file

@ -60,7 +60,7 @@ void TextDestGuiEngine::gotText(const StringMap &fields)
}
/******************************************************************************/
void TextDestGuiEngine::gotText(std::wstring text)
void TextDestGuiEngine::gotText(const std::wstring &text)
{
m_engine->getScriptIface()->handleMainMenuEvent(wide_to_utf8(text));
}
@ -540,7 +540,7 @@ bool GUIEngine::setTexture(texture_layer layer, std::string texturepath,
}
/******************************************************************************/
bool GUIEngine::downloadFile(std::string url, std::string target)
bool GUIEngine::downloadFile(const std::string &url, const std::string &target)
{
#if USE_CURL
std::ofstream target_file(target.c_str(), std::ios::out | std::ios::binary);