oss/luanti
oss/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-06-27 16:36:03 +00:00
Code Wiki Activity

Client: Disable node specular shader effect (#16113)

Browse source 
This feature needs a proper API integration to result in a correct
in-game appearance. See #15898 for details.

This is a band-aid solution for the 5.12.0 release.
This commit is contained in:
SmallJoker 2025-05-17 15:02:47 +02:00 • committed by GitHub
parent d11d90fb8d
commit 3020c192b2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 3 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

5
builtin/settingtypes.txt
View file

@ -872,11 +872,6 @@ enable_volumetric_lighting (Volumetric lighting) bool false
# Requires: enable_dynamic_shadows # Requires: enable_dynamic_shadows
enable_translucent_foliage (Translucent foliage) bool false enable_translucent_foliage (Translucent foliage) bool false
# Apply specular shading to nodes.
#
# Requires: enable_dynamic_shadows
enable_node_specular (Node specular) bool false
# When enabled, liquid reflections are simulated. # When enabled, liquid reflections are simulated.
# #
# Requires: enable_waving_water, enable_dynamic_shadows # Requires: enable_waving_water, enable_dynamic_shadows

4
src/client/shader.cpp
View file

@ -214,7 +214,9 @@ public:
if (g_settings->getBool("enable_translucent_foliage")) if (g_settings->getBool("enable_translucent_foliage"))
constants["ENABLE_TRANSLUCENT_FOLIAGE"] = 1; constants["ENABLE_TRANSLUCENT_FOLIAGE"] = 1;
if (g_settings->getBool("enable_node_specular")) // FIXME: The node specular effect is currently disabled due to mixed in-game
// results. This shader should not be applied to all nodes equally. See #15898
if (false)
constants["ENABLE_NODE_SPECULAR"] = 1; constants["ENABLE_NODE_SPECULAR"] = 1;
s32 shadow_filter = g_settings->getS32("shadow_filters"); s32 shadow_filter = g_settings->getS32("shadow_filters");

1
src/defaultsettings.cpp
View file

@ -340,7 +340,6 @@ void set_default_settings()
settings->setDefault("enable_volumetric_lighting", "false"); settings->setDefault("enable_volumetric_lighting", "false");
settings->setDefault("enable_water_reflections", "false"); settings->setDefault("enable_water_reflections", "false");
settings->setDefault("enable_translucent_foliage", "false"); settings->setDefault("enable_translucent_foliage", "false");
settings->setDefault("enable_node_specular", "false");
// Effects Shadows // Effects Shadows
settings->setDefault("enable_dynamic_shadows", "false"); settings->setDefault("enable_dynamic_shadows", "false");