oss/luanti
oss/luanti
1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-06-27 16:36:03 +00:00
Code Wiki Activity

Protect Player::hud from concurrent modifications

Browse source 
Sometimes HUD can be modified by ServerThread and EmergeThread results in a crash on client side because the HUD is not correct
This commit is contained in:
Loic Blot 2015-03-22 20:09:44 +01:00
parent d6638b4300
commit 0e5e49736c
2 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/player.cpp
View file

@ -240,6 +240,7 @@ void Player::deSerialize(std::istream &is, std::string playername)
u32 Player::addHud(HudElement *toadd)
{
JMutexAutoLock lock(m_mutex);
u32 id = getFreeHudID();
if (id < hud.size())
@ -252,6 +253,8 @@ u32 Player::addHud(HudElement *toadd)
HudElement* Player::getHud(u32 id)
{
JMutexAutoLock lock(m_mutex);
if (id < hud.size())
return hud[id];
@ -260,6 +263,8 @@ HudElement* Player::getHud(u32 id)
HudElement* Player::removeHud(u32 id)
{
JMutexAutoLock lock(m_mutex);
HudElement* retval = NULL;
if (id < hud.size()) {
retval = hud[id];
@ -270,6 +275,8 @@ HudElement* Player::removeHud(u32 id)
void Player::clearHud()
{
JMutexAutoLock lock(m_mutex);
while(!hud.empty()) {
delete hud.back();
hud.pop_back();