1
0
Fork 0
mirror of https://github.com/luanti-org/luanti.git synced 2025-06-27 16:36:03 +00:00

Optimize minetest.get_(all)_craft_recipe(s)

Signed off by: ShadowNinja, kwolekr
This commit is contained in:
gregorycu 2015-01-27 00:46:55 +11:00 committed by kwolekr
parent 1e4fb80d46
commit 03e0dd33a8
3 changed files with 107 additions and 180 deletions

View file

@ -27,6 +27,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
#include "gamedef.h"
#include "inventory.h"
#include "util/serialize.h"
#include "util/numeric.h"
#include "strfnd.h"
#include "exceptions.h"
@ -931,85 +932,30 @@ public:
}
return false;
}
virtual bool getCraftRecipe(CraftInput &input, CraftOutput &output,
IGameDef *gamedef) const
{
CraftOutput tmpout;
tmpout.item = "";
tmpout.time = 0;
// If output item is empty, abort.
if(output.item.empty())
return false;
// Walk crafting definitions from back to front, so that later
// definitions can override earlier ones.
for(std::vector<CraftDefinition*>::const_reverse_iterator
i = m_craft_definitions.rbegin();
i != m_craft_definitions.rend(); i++)
{
CraftDefinition *def = *i;
/*infostream<<"Checking "<<input.dump()<<std::endl
<<" against "<<def->dump()<<std::endl;*/
try {
tmpout = def->getOutput(input, gamedef);
if((tmpout.item.substr(0,output.item.length()) == output.item) &&
((tmpout.item[output.item.length()] == 0) ||
(tmpout.item[output.item.length()] == ' ')))
{
// Get output, then decrement input (if requested)
input = def->getInput(output, gamedef);
return true;
}
}
catch(SerializationError &e)
{
errorstream<<"getCraftResult: ERROR: "
<<"Serialization error in recipe "
<<def->dump()<<std::endl;
// then go on with the next craft definition
}
}
return false;
}
virtual std::vector<CraftDefinition*> getCraftRecipes(CraftOutput &output,
IGameDef *gamedef) const
IGameDef *gamedef, unsigned limit=0) const
{
std::vector<CraftDefinition*> recipes_list;
CraftInput input;
CraftOutput tmpout;
tmpout.item = "";
tmpout.time = 0;
std::vector<CraftDefinition*> recipes;
for(std::vector<CraftDefinition*>::const_reverse_iterator
i = m_craft_definitions.rbegin();
i != m_craft_definitions.rend(); i++)
{
CraftDefinition *def = *i;
std::map<std::string, std::vector<CraftDefinition*> >::const_iterator
vec_iter = m_output_craft_definitions.find(output.item);
/*infostream<<"Checking "<<input.dump()<<std::endl
<<" against "<<def->dump()<<std::endl;*/
if (vec_iter == m_output_craft_definitions.end())
return recipes;
try {
tmpout = def->getOutput(input, gamedef);
if(tmpout.item.substr(0,output.item.length()) == output.item)
{
// Get output, then decrement input (if requested)
input = def->getInput(output, gamedef);
recipes_list.push_back(*i);
}
}
catch(SerializationError &e)
{
errorstream<<"getCraftResult: ERROR: "
<<"Serialization error in recipe "
<<def->dump()<<std::endl;
// then go on with the next craft definition
}
const std::vector<CraftDefinition*> &vec = vec_iter->second;
recipes.reserve(limit ? MYMIN(limit, vec.size()) : vec.size());
for (std::vector<CraftDefinition*>::const_reverse_iterator
it = vec.rbegin(); it != vec.rend(); ++it) {
if (limit && recipes.size() >= limit)
break;
recipes.push_back(*it);
}
return recipes_list;
return recipes;
}
virtual std::string dump() const
{
@ -1023,11 +969,16 @@ public:
}
return os.str();
}
virtual void registerCraft(CraftDefinition *def)
virtual void registerCraft(CraftDefinition *def, IGameDef *gamedef)
{
verbosestream<<"registerCraft: registering craft definition: "
<<def->dump()<<std::endl;
m_craft_definitions.push_back(def);
CraftInput input;
std::string output_name = craftGetItemName(
def->getOutput(input, gamedef).item, gamedef);
m_output_craft_definitions[output_name].push_back(def);
}
virtual void clear()
{
@ -1037,6 +988,7 @@ public:
delete *i;
}
m_craft_definitions.clear();
m_output_craft_definitions.clear();
}
virtual void serialize(std::ostream &os) const
{
@ -1053,7 +1005,7 @@ public:
os<<serializeString(tmp_os.str());
}
}
virtual void deSerialize(std::istream &is)
virtual void deSerialize(std::istream &is, IGameDef *gamedef)
{
// Clear everything
clear();
@ -1067,11 +1019,12 @@ public:
std::istringstream tmp_is(deSerializeString(is), std::ios::binary);
CraftDefinition *def = CraftDefinition::deSerialize(tmp_is);
// Register
registerCraft(def);
registerCraft(def, gamedef);
}
}
private:
std::vector<CraftDefinition*> m_craft_definitions;
std::map<std::string, std::vector<CraftDefinition*> > m_output_craft_definitions;
};
IWritableCraftDefManager* createCraftDefManager()