mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2025-06-27 16:35:57 +00:00
A fix for a bug introduced by me earlier, where attempting to parse an issue reference in an empty token would crash. An empty token occurs if the search string is `\` or `"` (among other scenarios, probably). I'll make another PR that avoids having empty tokens (seems like a good idea). ### Tests - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [x] I do not want this change to show in the release notes. - [ ] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8260 Reviewed-by: Shiny Nematoda <snematoda@noreply.codeberg.org> Co-authored-by: Danko Aleksejevs <danko@very.lv> Co-committed-by: Danko Aleksejevs <danko@very.lv>
203 lines
3.1 KiB
Go
203 lines
3.1 KiB
Go
// Copyright 2025 The Forgejo Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package internal
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
type testIssueQueryStringOpt struct {
|
|
Keyword string
|
|
Results []Token
|
|
}
|
|
|
|
var testOpts = []testIssueQueryStringOpt{
|
|
{
|
|
Keyword: "Hello",
|
|
Results: []Token{
|
|
{
|
|
Term: "Hello",
|
|
Fuzzy: true,
|
|
Kind: BoolOptShould,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
Keyword: "Hello World",
|
|
Results: []Token{
|
|
{
|
|
Term: "Hello",
|
|
Fuzzy: true,
|
|
Kind: BoolOptShould,
|
|
},
|
|
{
|
|
Term: "World",
|
|
Fuzzy: true,
|
|
Kind: BoolOptShould,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
Keyword: "+Hello +World",
|
|
Results: []Token{
|
|
{
|
|
Term: "Hello",
|
|
Fuzzy: true,
|
|
Kind: BoolOptMust,
|
|
},
|
|
{
|
|
Term: "World",
|
|
Fuzzy: true,
|
|
Kind: BoolOptMust,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
Keyword: "+Hello World",
|
|
Results: []Token{
|
|
{
|
|
Term: "Hello",
|
|
Fuzzy: true,
|
|
Kind: BoolOptMust,
|
|
},
|
|
{
|
|
Term: "World",
|
|
Fuzzy: true,
|
|
Kind: BoolOptShould,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
Keyword: "+Hello -World",
|
|
Results: []Token{
|
|
{
|
|
Term: "Hello",
|
|
Fuzzy: true,
|
|
Kind: BoolOptMust,
|
|
},
|
|
{
|
|
Term: "World",
|
|
Fuzzy: true,
|
|
Kind: BoolOptNot,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
Keyword: "\"Hello World\"",
|
|
Results: []Token{
|
|
{
|
|
Term: "Hello World",
|
|
Fuzzy: false,
|
|
Kind: BoolOptShould,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
Keyword: "+\"Hello World\"",
|
|
Results: []Token{
|
|
{
|
|
Term: "Hello World",
|
|
Fuzzy: false,
|
|
Kind: BoolOptMust,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
Keyword: "-\"Hello World\"",
|
|
Results: []Token{
|
|
{
|
|
Term: "Hello World",
|
|
Fuzzy: false,
|
|
Kind: BoolOptNot,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
Keyword: "\"+Hello -World\"",
|
|
Results: []Token{
|
|
{
|
|
Term: "+Hello -World",
|
|
Fuzzy: false,
|
|
Kind: BoolOptShould,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
Keyword: "\\+Hello", // \+Hello => +Hello
|
|
Results: []Token{
|
|
{
|
|
Term: "+Hello",
|
|
Fuzzy: true,
|
|
Kind: BoolOptShould,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
Keyword: "\\\\Hello", // \\Hello => \Hello
|
|
Results: []Token{
|
|
{
|
|
Term: "\\Hello",
|
|
Fuzzy: true,
|
|
Kind: BoolOptShould,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
Keyword: "\\\"Hello", // \"Hello => "Hello
|
|
Results: []Token{
|
|
{
|
|
Term: "\"Hello",
|
|
Fuzzy: true,
|
|
Kind: BoolOptShould,
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
func TestIssueQueryString(t *testing.T) {
|
|
var opt SearchOptions
|
|
for _, res := range testOpts {
|
|
t.Run(opt.Keyword, func(t *testing.T) {
|
|
opt.Keyword = res.Keyword
|
|
tokens, err := opt.Tokens()
|
|
require.NoError(t, err)
|
|
assert.Equal(t, res.Results, tokens)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestToken_ParseIssueReference(t *testing.T) {
|
|
var tk Token
|
|
{
|
|
tk.Term = "123"
|
|
id, err := tk.ParseIssueReference()
|
|
require.NoError(t, err)
|
|
assert.Equal(t, int64(123), id)
|
|
}
|
|
{
|
|
tk.Term = "#123"
|
|
id, err := tk.ParseIssueReference()
|
|
require.NoError(t, err)
|
|
assert.Equal(t, int64(123), id)
|
|
}
|
|
{
|
|
tk.Term = "!123"
|
|
id, err := tk.ParseIssueReference()
|
|
require.NoError(t, err)
|
|
assert.Equal(t, int64(123), id)
|
|
}
|
|
{
|
|
tk.Term = "text"
|
|
_, err := tk.ParseIssueReference()
|
|
require.Error(t, err)
|
|
}
|
|
{
|
|
tk.Term = ""
|
|
_, err := tk.ParseIssueReference()
|
|
require.Error(t, err)
|
|
}
|
|
}
|