1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-10-05 19:30:58 +00:00
forgejo/modules/storage
oliverpool 3de4b351a2 [v11.0/forgejo] storage test: reader should not be closed on save (#9031)
Backport of the fixes for #8529 (v11 is currently not affected because minio-client is an older version. Porting the tests should help in preventing future breakages).

- #8541: storage test (reader should not get closed)
- #8527 #8816: defer uploader.Close (most robust way)
- #8166: enable storage tests

The test can be run locally:

```
docker run --rm -e MINIO_DOMAIN=minio -e MINIO_ROOT_USER=123456 -e MINIO_ROOT_PASSWORD=12345678 -p 9000:9000  data.forgejo.org/oci/bitnami/minio:2024.8.17
```

```
TEST_MINIO_ENDPOINT=localhost:9000  go test -v -run ^TestMinioStorageIterator$ ./modules/storage
```

### Release notes

- [x] I do not want this change to show in the release notes.
- [ ] I want the title to show in the release notes with a link to this pull request.
- [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title.

Co-authored-by: Earl Warren <contact@earl-warren.org>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9031
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: oliverpool <git@olivier.pfad.fr>
Co-committed-by: oliverpool <git@olivier.pfad.fr>
2025-08-26 10:20:00 +02:00
..
testdata feat: add support for a credentials chain for minio access (#31051) 2024-06-02 10:14:09 +02:00
helper.go Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) 2024-11-05 09:33:15 +01:00
helper_test.go Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) 2024-11-05 09:33:15 +01:00
local.go [v11.0/forgejo] chore: branding import path (#7354) 2025-03-27 20:13:05 +00:00
local_test.go [v11.0/forgejo] chore: branding import path (#7354) 2025-03-27 20:13:05 +00:00
minio.go [v11.0/forgejo] chore: branding import path (#7354) 2025-03-27 20:13:05 +00:00
minio_test.go [v11.0/forgejo] storage test: reader should not be closed on save (#9031) 2025-08-26 10:20:00 +02:00
storage.go [v11.0/forgejo] chore: branding import path (#7354) 2025-03-27 20:13:05 +00:00
storage_test.go [v11.0/forgejo] storage test: reader should not be closed on save (#9031) 2025-08-26 10:20:00 +02:00