1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-10-20 19:52:04 +00:00
forgejo/services/mailer
Mathieu Fenniak 89e0323351 fix: respect UI DEFAULT_SHOW_FULL_NAME setting in email From: headers (#9307)
Changes email's `From` field to respect the server's `DEFAULT_SHOW_FULL_NAME` setting, bringing consistency between seeing an email from a user, opening the related issue, and seeing a different name in Forgejo's web UI.

Manually tested by varying the `DEFAULT_SHOW_FULL_NAME` server property, enabling and disabling it:
![image](/attachments/234b26b5-da8a-4220-955e-f20c61e418e8)

Fixes #9149.

## Checklist

The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org).

### Tests

- I added test coverage for Go changes...
  - [x] in their respective `*_test.go` for unit tests.
  - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server.
- I added test coverage for JavaScript changes...
  - [ ] in `web_src/js/*.test.js` if it can be unit tested.
  - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)).
- Performed manual testing with

### Documentation

- [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change.
- [ ] I did not document these changes and I do not expect someone else to do it.

### Release notes

- [ ] I do not want this change to show in the release notes.
- [x] I want the title to show in the release notes with a link to this pull request.
- [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9307
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net>
Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net>
2025-09-16 15:19:06 +02:00
..
incoming chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
token chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
mail.go fix: respect UI DEFAULT_SHOW_FULL_NAME setting in email From: headers (#9307) 2025-09-16 15:19:06 +02:00
mail_actions.go feat(build): improve lint-locale-usage further (#8736) 2025-08-27 23:47:34 +02:00
mail_actions_now_done_test.go fix(email): actions notification template confuses branch with PR (#8448) 2025-07-09 09:43:33 +02:00
mail_admin_new_user.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
mail_admin_new_user_test.go send mail on failed or recovered workflow run (#7509) 2025-04-29 06:58:05 +00:00
mail_auth_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
mail_comment.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
mail_issue.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
mail_release.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
mail_repo.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
mail_team_invite.go chore(cleanup): replaces unnecessary calls to formatting functions by non-formatting equivalents (#7994) 2025-05-29 17:34:29 +02:00
mail_test.go fix: respect UI DEFAULT_SHOW_FULL_NAME setting in email From: headers (#9307) 2025-09-16 15:19:06 +02:00
mailer.go Update module github.com/jhillyerd/enmime/v2 to v2.2.0 (forgejo) (#8254) 2025-06-26 08:49:20 +02:00
mailer_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
main_test.go fix: only send Forgejo Actions notifications to one user (#8227) 2025-06-21 12:15:38 +02:00
notify.go fix: cancelled or skipped runs are not failures for notifications (#8366) 2025-07-03 22:53:55 +02:00