mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2025-08-01 17:38:33 +00:00
chore: QoL improvements to tests (#7917)
- Use mock helper functions, instead of home-brew solutions. - Disable cron jobs that are not important to be run during integration tests and might even interfere. - Avoid sleeping unnecessary, if there's some requirement then sleep or retry until that requirement is met. - Avoid trying to deliver webhooks that will always result in a failure. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7917 Reviewed-by: Michael Kriese <michael.kriese@gmx.de> Co-authored-by: Gusted <postmaster@gusted.xyz> Co-committed-by: Gusted <postmaster@gusted.xyz>
This commit is contained in:
parent
112ba66637
commit
fa2a135f68
44 changed files with 155 additions and 264 deletions
|
@ -23,8 +23,7 @@ import (
|
|||
|
||||
func TestSignup(t *testing.T) {
|
||||
defer tests.PrepareTestEnv(t)()
|
||||
|
||||
setting.Service.EnableCaptcha = false
|
||||
defer test.MockVariableValue(&setting.Service.EnableCaptcha, false)()
|
||||
|
||||
req := NewRequestWithValues(t, "POST", "/user/sign_up", map[string]string{
|
||||
"user_name": "exampleUser",
|
||||
|
@ -41,9 +40,8 @@ func TestSignup(t *testing.T) {
|
|||
|
||||
func TestSignupAsRestricted(t *testing.T) {
|
||||
defer tests.PrepareTestEnv(t)()
|
||||
|
||||
setting.Service.EnableCaptcha = false
|
||||
setting.Service.DefaultUserIsRestricted = true
|
||||
defer test.MockVariableValue(&setting.Service.EnableCaptcha, false)()
|
||||
defer test.MockVariableValue(&setting.Service.DefaultUserIsRestricted, true)()
|
||||
|
||||
req := NewRequestWithValues(t, "POST", "/user/sign_up", map[string]string{
|
||||
"user_name": "restrictedUser",
|
||||
|
@ -63,8 +61,7 @@ func TestSignupAsRestricted(t *testing.T) {
|
|||
|
||||
func TestSignupEmail(t *testing.T) {
|
||||
defer tests.PrepareTestEnv(t)()
|
||||
|
||||
setting.Service.EnableCaptcha = false
|
||||
defer test.MockVariableValue(&setting.Service.EnableCaptcha, false)()
|
||||
|
||||
tests := []struct {
|
||||
email string
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue