From e34cdca720109e2d1c728b2ff1e5da9d2484a104 Mon Sep 17 00:00:00 2001 From: forgejo-backport-action Date: Wed, 10 Sep 2025 18:52:19 +0200 Subject: [PATCH] [v12.0/forgejo] chore: fix transient error in TestPatchStatus tests (#9239) **Backport:** https://codeberg.org/forgejo/forgejo/pulls/9236 wait on all pull requests before checking their conflict status because there is no guarantee one will be dealt with before another Refs https://codeberg.org/forgejo/forgejo/issues/8221#issuecomment-6849601 Co-authored-by: Earl Warren Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9239 Reviewed-by: Earl Warren Co-authored-by: forgejo-backport-action Co-committed-by: forgejo-backport-action --- tests/integration/patch_status_test.go | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/tests/integration/patch_status_test.go b/tests/integration/patch_status_test.go index 4a5edccf59..ac41860641 100644 --- a/tests/integration/patch_status_test.go +++ b/tests/integration/patch_status_test.go @@ -144,11 +144,16 @@ func TestPatchStatus(t *testing.T) { require.NoError(t, git.NewCommand(t.Context(), "push", "origin", "HEAD:main").Run(&git.RunOpts{Dir: dstPath})) require.NoError(t, git.NewCommand(t.Context(), "switch", "normal").Run(&git.RunOpts{Dir: dstPath})) + assertConflictAndLoadBean := func(t *testing.T, pr *issues_model.PullRequest, flow string) *issues_model.PullRequest { + t.Helper() + assert.Eventually(t, func() bool { + return unittest.AssertExistsAndLoadBean(t, pr, flow).Status == issues_model.PullRequestStatusConflict + }, time.Second*30, time.Millisecond*200) + return pr + } // Wait until status check queue is done, we cannot access the queue's // internal information so we rely on the status of the patch being changed. - assert.Eventually(t, func() bool { - return unittest.AssertExistsAndLoadBean(t, &issues_model.PullRequest{ID: normalAGitPR.ID}).Status == issues_model.PullRequestStatusConflict - }, time.Second*30, time.Millisecond*200) + _ = assertConflictAndLoadBean(t, &issues_model.PullRequest{ID: normalAGitPR.ID}, "flow = 1") test := func(t *testing.T, pr *issues_model.PullRequest) { t.Helper() @@ -165,7 +170,7 @@ func TestPatchStatus(t *testing.T) { t.Run("Existing", func(t *testing.T) { defer tests.PrintCurrentTest(t)() - pr := unittest.AssertExistsAndLoadBean(t, &issues_model.PullRequest{BaseRepoID: repo.ID, HeadRepoID: forkRepo.ID, HeadBranch: "normal"}, "flow = 0") + pr := assertConflictAndLoadBean(t, &issues_model.PullRequest{BaseRepoID: repo.ID, HeadRepoID: forkRepo.ID, HeadBranch: "normal"}, "flow = 0") test(t, pr) testAutomergeQueued(t, pr, issues_model.PullRequestStatusConflict) }) @@ -176,7 +181,7 @@ func TestPatchStatus(t *testing.T) { require.NoError(t, git.NewCommand(t.Context(), "push", "fork", "HEAD:conflict").Run(&git.RunOpts{Dir: dstPath})) testPullCreateDirectly(t, session, repo.OwnerName, repo.Name, repo.DefaultBranch, forkRepo.OwnerName, forkRepo.Name, "conflict", "across repo conflict") - test(t, unittest.AssertExistsAndLoadBean(t, &issues_model.PullRequest{BaseRepoID: repo.ID, HeadRepoID: forkRepo.ID, HeadBranch: "conflict"}, "flow = 0")) + test(t, assertConflictAndLoadBean(t, &issues_model.PullRequest{BaseRepoID: repo.ID, HeadRepoID: forkRepo.ID, HeadBranch: "conflict"}, "flow = 0")) }) })