From a36e5bb83d2e79b4ddfe13ab9973952439dde375 Mon Sep 17 00:00:00 2001 From: Daksh Bhayana Date: Tue, 17 Jun 2025 07:12:22 +0530 Subject: [PATCH] Removed Mark visible button from org/members --- routers/web/org/members.go | 10 ++++++---- routers/web/user/setting/profile.go | 20 ++++++++++---------- templates/org/member/members.tmpl | 10 ---------- 3 files changed, 16 insertions(+), 24 deletions(-) diff --git a/routers/web/org/members.go b/routers/web/org/members.go index 90c2c3a9af..44c3edf135 100644 --- a/routers/web/org/members.go +++ b/routers/web/org/members.go @@ -6,6 +6,7 @@ package org import ( "net/http" + "forgejo.org/models" "forgejo.org/models/organization" "forgejo.org/modules/base" @@ -18,6 +19,7 @@ import ( const ( // tplMembers template for organization members page tplMembers base.TplName = "org/member/members" + tplSettingsOrganization base.TplName = "/user/settings/organization" ) // Members render organization users page @@ -79,7 +81,7 @@ func Members(ctx *context.Context) { func MembersAction(ctx *context.Context) { uid := ctx.FormInt64("uid") if uid == 0 { - ctx.Redirect("/user/settings/organization") + ctx.Redirect(tplSettingsOrganization) return } @@ -106,7 +108,7 @@ func MembersAction(ctx *context.Context) { err = models.RemoveOrgUser(ctx, org.ID, uid) if organization.IsErrLastOrgOwner(err) { ctx.Flash.Error(ctx.Tr("form.last_org_owner")) - ctx.JSONRedirect("/user/settings/organization") + ctx.JSONRedirect(tplSettingsOrganization) return } case "leave": @@ -118,7 +120,7 @@ func MembersAction(ctx *context.Context) { }) } else if organization.IsErrLastOrgOwner(err) { ctx.Flash.Error(ctx.Tr("form.last_org_owner")) - ctx.JSONRedirect("/user/settings/organization") + ctx.JSONRedirect(tplSettingsOrganization) } else { log.Error("RemoveOrgUser(%d,%d): %v", org.ID, ctx.Doer.ID, err) } @@ -134,7 +136,7 @@ func MembersAction(ctx *context.Context) { return } - redirect := "/user/settings/organization" + redirect := tplSettingsOrganization if ctx.Params(":action") == "leave" { redirect = setting.AppSubURL + "/" } diff --git a/routers/web/user/setting/profile.go b/routers/web/user/setting/profile.go index 61af2b20cc..167352dce6 100644 --- a/routers/web/user/setting/profile.go +++ b/routers/web/user/setting/profile.go @@ -216,19 +216,19 @@ func Organization(ctx *context.Context) { } // Get public membership status for each organization - orgsIsPublicMember := make(map[int64]bool) - for _, org := range orgs { - isPublic, err := organization.IsPublicMembership(ctx, org.ID, ctx.Doer.ID) - if err != nil { - ctx.ServerError("IsPublicMembership", err) - return - } - orgsIsPublicMember[org.ID] = isPublic - } + orgsIsPublicMember := make(map[int64]bool) + for _, org := range orgs { + isPublic, err := organization.IsPublicMembership(ctx, org.ID, ctx.Doer.ID) + if err != nil { + ctx.ServerError("IsPublicMembership", err) + return + } + orgsIsPublicMember[org.ID] = isPublic + } ctx.Data["Orgs"] = orgs ctx.Data["Total"] = total - ctx.Data["OrgsIsPublicMember"] = orgsIsPublicMember + ctx.Data["OrgsIsPublicMember"] = orgsIsPublicMember pager := context.NewPagination(int(total), opts.PageSize, opts.Page, 5) pager.SetDefaultParams(ctx) ctx.Data["Page"] = pager diff --git a/templates/org/member/members.tmpl b/templates/org/member/members.tmpl index dccf588f6a..2a3268833e 100644 --- a/templates/org/member/members.tmpl +++ b/templates/org/member/members.tmpl @@ -14,9 +14,6 @@
{{template "shared/user/name" .}} - {{if not $isPublic}} - {{ctx.Locale.Tr "org.members.private"}} - {{end}}
{{if not $.PublicOnly}}
@@ -38,13 +35,6 @@ {{end}}
- {{if or (eq $.SignedUser.ID .ID) $.IsOrganizationOwner}} - {{if $isPublic}} - {{svg "octicon-eye-closed" 12 "icon"}}{{ctx.Locale.Tr "org.members.public_helper"}} - {{else}} - {{svg "octicon-eye" 12 "icon"}}{{ctx.Locale.Tr "org.members.private_helper"}} - {{end}} - {{end}} {{if eq $.SignedUser.ID .ID}}