[F3] Forgejo driver and CLI

user, topic, project, label, milestone, repository, pull_request, release, asset, comment, reaction, review providers Signed-off-by: Earl Warren <contact@earl-warren.org> Preserve file size when creating attachments Introduced in c6f5029708 repoList.LoadAttributes has a ctx argument now Rename `repo.GetOwner` to `repo.LoadOwner` bd66fa586a upgrade to the latest gof3 (cherry picked from commit c770713656) [F3] ID remapping logic is in place, remove workaround (cherry picked from commit d0fee30167) [F3] it is experimental, do not enable by default (cherry picked from commit de325b21d0) (cherry picked from commit 547e7b3c40) (cherry picked from commit 820df3a56b) (cherry picked from commit eaba87689b) (cherry picked from commit 1b86896b3b) (cherry picked from commit 0046aac1c6) (cherry picked from commit f14220df8f) (cherry picked from commit 559b731001) (cherry picked from commit 801f7d600d) (cherry picked from commit 6aa76e9bcf) (cherry picked from commit a8757dcb07) [F3] promote F3 users to matching OAuth2 users on first sign-in (cherry picked from commit bd7fef7496) (cherry picked from commit 07412698e8) (cherry picked from commit d143e5b2a3) [F3] upgrade to gof3 50a6e740ac04 Add new methods GetIDString() & SetIDString() & ToFormatInterface() Change the prototype of the fixture function (cherry picked from commit d7b263ff8b) (cherry picked from commit b3eaf2249d) (cherry picked from commit d492ddd9bb) [F3] add GetLocalMatchingRemote with a default implementation (cherry picked from commit 0a22015039) (cherry picked from commit f1310c38fb) (cherry picked from commit deb68552f2) [F3] GetLocalMatchingRemote for user (cherry picked from commit e73cb837f5) (cherry picked from commit a24bc0b85e) (cherry picked from commit 846a522ecc) [F3] GetAdminUser now has a ctx argument (cherry picked from commit 37357a92af) (cherry picked from commit 660bc1673c) (cherry picked from commit 72d692a767) [F3] introduce UserTypeF3 To avoid conflicts should UserTypeRemoteUser be used differently by Gitea (cherry picked from commit 6de2701bb3) [F3] user.Put: idempotency (cherry picked from commit 821e38573c) (cherry picked from commit f7638f5414) [F3] upgrade to urfave v2 (cherry picked from commit cc3dbdfd1d) [F3] update gof3 (cherry picked from commit 2eee960751) [F3] move f3 under forgejo-cli * simplify the tests by re-using the forgejo-cli helpers to capture the output * unify CmdF3 to be structured in the same way CmdActions is (cherry picked from commit 4c9fe58b74) [F3] replace f3 with forgejo-cli f3 (cherry picked from commit 7ba7ceef1b) [F3] s/ListOptions/Paginator/ [F3] user: add unit tests [F3] user comparison of F3 managed users is on content [F3] issue: add unit tests [F3] gof3 now has one more argument to Put() [F3] re-use gof3 unit tests for the driver (cherry picked from commit af7ee6200c) Conflicts: tests/integration/integration_test.go because of some code removed in forgejo-development, trivial context conflict resolution [F3] more idempotent tests (#1275) Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/1275 Co-authored-by: Loïc Dachary <loic@dachary.org> Co-committed-by: Loïc Dachary <loic@dachary.org> [F3] tests: do SQL update if nothing changes [F3] tests comment idempotence [F3] tests milestone idempotence [F3] tests pull_request idempotence [F3] tests release idempotence [F3] tests asset idempotence [F3] tests project idempotence [F3] tests review idempotence
2025-09-15 18:56:59 +00:00 · 2022-09-06 14:35:43 +10:00 · 2022-09-06 14:35:43 +10:00 · 91038bb4e8
commit 91038bb4e8
parent 70fffdc61d
40 changed files with 3944 additions and 49 deletions
--- a/services/f3/driver/issue.go
+++ b/services/f3/driver/issue.go
@ -0,0 +1,234 @@
+// SPDX-License-Identifier: MIT
+
+package driver
+
+import (
+	"context"
+	"fmt"
+
+	"code.gitea.io/gitea/models/db"
+	issues_model "code.gitea.io/gitea/models/issues"
+	repo_model "code.gitea.io/gitea/models/repo"
+	user_model "code.gitea.io/gitea/models/user"
+	"code.gitea.io/gitea/modules/git"
+	"code.gitea.io/gitea/modules/timeutil"
+	issue_service "code.gitea.io/gitea/services/issue"
+
+	"lab.forgefriends.org/friendlyforgeformat/gof3/format"
+	"lab.forgefriends.org/friendlyforgeformat/gof3/util"
+)
+
+type Issue struct {
+	issues_model.Issue
+}
+
+func IssueConverter(f *issues_model.Issue) *Issue {
+	return &Issue{
+		Issue: *f,
+	}
+}
+
+func (o Issue) GetID() int64 {
+	return o.Index
+}
+
+func (o Issue) GetIDString() string {
+	return fmt.Sprintf("%d", o.GetID())
+}
+
+func (o *Issue) SetID(id int64) {
+	o.Index = id
+}
+
+func (o *Issue) SetIDString(id string) {
+	o.SetID(util.ParseInt(id))
+}
+
+func (o *Issue) IsNil() bool {
+	return o.Index == 0
+}
+
+func (o *Issue) Equals(other *Issue) bool {
+	return (o.Title == other.Title)
+}
+
+func (o *Issue) ToFormatInterface() format.Interface {
+	return o.ToFormat()
+}
+
+func (o *Issue) ToFormat() *format.Issue {
+	var milestone string
+	if o.Milestone != nil {
+		milestone = o.Milestone.Name
+	}
+
+	labels := make([]string, 0, len(o.Labels))
+	for _, label := range o.Labels {
+		labels = append(labels, label.Name)
+	}
+
+	var assignees []string
+	for i := range o.Assignees {
+		assignees = append(assignees, o.Assignees[i].Name)
+	}
+
+	return &format.Issue{
+		Common:    format.NewCommon(o.Index),
+		Title:     o.Title,
+		PosterID:  format.NewUserReference(o.Poster.ID),
+		Content:   o.Content,
+		Milestone: milestone,
+		State:     string(o.State()),
+		Created:   o.CreatedUnix.AsTime(),
+		Updated:   o.UpdatedUnix.AsTime(),
+		Closed:    o.ClosedUnix.AsTimePtr(),
+		IsLocked:  o.IsLocked,
+		Labels:    labels,
+		Assignees: assignees,
+	}
+}
+
+func (o *Issue) FromFormat(issue *format.Issue) {
+	labels := make([]*issues_model.Label, 0, len(issue.Labels))
+	for _, label := range issue.Labels {
+		labels = append(labels, &issues_model.Label{Name: label})
+	}
+
+	assignees := make([]*user_model.User, 0, len(issue.Assignees))
+	for _, a := range issue.Assignees {
+		assignees = append(assignees, &user_model.User{
+			Name: a,
+		})
+	}
+
+	*o = Issue{
+		Issue: issues_model.Issue{
+			Title:    issue.Title,
+			Index:    issue.GetID(),
+			PosterID: issue.PosterID.GetID(),
+			Poster: &user_model.User{
+				ID: issue.PosterID.GetID(),
+			},
+			Content: issue.Content,
+			Milestone: &issues_model.Milestone{
+				Name: issue.Milestone,
+			},
+			IsClosed:    issue.State == "closed",
+			CreatedUnix: timeutil.TimeStamp(issue.Created.Unix()),
+			UpdatedUnix: timeutil.TimeStamp(issue.Updated.Unix()),
+			ClosedUnix:  timeutil.TimeStamp(issue.Closed.Unix()),
+			IsLocked:    issue.IsLocked,
+			Labels:      labels,
+			Assignees:   assignees,
+		},
+	}
+}
+
+type IssueProvider struct {
+	BaseProviderWithProjectProvider
+}
+
+func (o *IssueProvider) ToFormat(ctx context.Context, issue *Issue) *format.Issue {
+	return issue.ToFormat()
+}
+
+func (o *IssueProvider) FromFormat(ctx context.Context, i *format.Issue) *Issue {
+	var issue Issue
+	issue.FromFormat(i)
+	if i.Milestone != "" {
+		issue.Milestone.ID = o.project.milestones.GetID(issue.Milestone.Name)
+	}
+	for _, label := range issue.Labels {
+		label.ID = o.project.labels.GetID(label.Name)
+	}
+	return &issue
+}
+
+func (o *IssueProvider) GetObjects(ctx context.Context, user *User, project *Project, page int) []*Issue {
+	issues, err := issues_model.Issues(ctx, &issues_model.IssuesOptions{
+		Paginator: &db.ListOptions{Page: page, PageSize: o.g.perPage},
+		RepoIDs:   []int64{project.GetID()},
+	})
+	if err != nil {
+		panic(fmt.Errorf("error while listing issues: %v", err))
+	}
+
+	return util.ConvertMap[*issues_model.Issue, *Issue](issues, IssueConverter)
+}
+
+func (o *IssueProvider) ProcessObject(ctx context.Context, user *User, project *Project, issue *Issue) {
+	if err := (&issue.Issue).LoadAttributes(ctx); err != nil {
+		panic(true)
+	}
+}
+
+func (o *IssueProvider) Get(ctx context.Context, user *User, project *Project, exemplar *Issue) *Issue {
+	id := exemplar.GetID()
+	issue, err := issues_model.GetIssueByIndex(ctx, project.GetID(), id)
+	if issues_model.IsErrIssueNotExist(err) {
+		return &Issue{}
+	}
+	if err != nil {
+		panic(err)
+	}
+	i := IssueConverter(issue)
+	o.ProcessObject(ctx, user, project, i)
+	return i
+}
+
+func (o *IssueProvider) Put(ctx context.Context, user *User, project *Project, issue, existing *Issue) *Issue {
+	i := issue.Issue
+	i.RepoID = project.GetID()
+	labels := make([]int64, 0, len(i.Labels))
+	for _, label := range i.Labels {
+		labels = append(labels, label.ID)
+	}
+
+	var result *Issue
+
+	if existing == nil || existing.IsNil() {
+		if err := issues_model.NewIssue(&project.Repository, &i, labels, []string{}); err != nil {
+			panic(err)
+		}
+		result = IssueConverter(&i)
+	} else {
+		e := existing.Issue
+		if issue.GetID() != existing.GetID() {
+			panic(fmt.Sprintf("issue.GetID() %d != existing.GetID() %d", issue.GetID(), existing.GetID()))
+		}
+		var u issues_model.Issue
+		u.Index = existing.GetID()
+		u.RepoID = project.GetID()
+		cols := make([]string, 0, 10)
+		if i.Title != e.Title {
+			u.Title = i.Title
+			cols = append(cols, "name")
+		}
+
+		if len(cols) > 0 {
+			if _, err := db.GetEngine(ctx).ID(existing.ID).Cols(cols...).Update(u); err != nil {
+				panic(err)
+			}
+		}
+
+		result = existing
+	}
+
+	return o.Get(ctx, user, project, result)
+}
+
+func (o *IssueProvider) Delete(ctx context.Context, user *User, project *Project, issue *Issue) *Issue {
+	m := o.Get(ctx, user, project, issue)
+	if !m.IsNil() {
+		repoPath := repo_model.RepoPath(user.Name, project.Name)
+		gitRepo, err := git.OpenRepository(ctx, repoPath)
+		if err != nil {
+			panic(err)
+		}
+		defer gitRepo.Close()
+		if err := issue_service.DeleteIssue(ctx, o.g.GetDoer(), gitRepo, &issue.Issue); err != nil {
+			panic(err)
+		}
+	}
+	return m
+}