1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-08-01 17:38:33 +00:00

[MODERATION] Refactor excluding watchers mechanism (squash)

This solves two bugs. One bug is that due to the JOIN with the
`forgejo_blocked_users` table, duplicated users were generated if a user
had more than one user blocked, this lead to receiving more than one
entry in the actions table. The other bug is that if a user blocked more
than one user, it would still receive a action entry by a
blocked user, because the SQL query would not exclude the other
duplicated users that was generated by the JOIN.

The new solution is somewhat non-optimal in my eyes, but it's better
than rewriting the query to become a potential perfomance blocker (usage
of WHERE IN, which cannot be rewritten to a JOIN). It simply removes the
watchers after it was retrieved by the SQL query.

(cherry picked from commit c63c00b39b)
(cherry picked from commit ad3cdc5705)
This commit is contained in:
Gusted 2024-01-15 00:22:06 +01:00 committed by Earl Warren
parent 9bb188176e
commit 8d3fab8944
No known key found for this signature in database
GPG key ID: 0579CB2928A78A00
5 changed files with 87 additions and 17 deletions

View file

@ -0,0 +1,16 @@
-
id: 1000
repo_id: 4
index: 1000
poster_id: 10
original_author_id: 0
name: issue for moderation
content: Hello there!
milestone_id: 0
priority: 0
is_closed: false
is_pull: false
num_comments: 0
created_unix: 1705939088
updated_unix: 1705939088
is_locked: false