mirror of
https://code.forgejo.org/forgejo/runner.git
synced 2025-08-06 17:40:58 +00:00
13ed94f5b7
This is a followup of https://code.forgejo.org/forgejo/act/pulls/170 so that it is possible to read a workflow without validation. It is not uncommon for Forgejo to read a workflow just to extract a few information from it, knowing it has been validated before. It would be a performance regression if schema validation happened in these cases. This is a port of https://github.com/nektos/act/pull/2717/files It is a breaking change in the context of Forgejo and Forgejo runner because it will need to add the new `validate` argument when reading workflows. Co-authored-by: ChristopherHX <christopher.homberger@web.de> Reviewed-on: https://code.forgejo.org/forgejo/act/pulls/180 Reviewed-by: Michael Kriese <michael.kriese@gmx.de> Co-authored-by: Earl Warren <contact@earl-warren.org> Co-committed-by: Earl Warren <contact@earl-warren.org>
58 lines
1.8 KiB
Go
58 lines
1.8 KiB
Go
package model
|
|
|
|
import (
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
log "github.com/sirupsen/logrus"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
type WorkflowPlanTest struct {
|
|
workflowPath string
|
|
errorMessage string
|
|
noWorkflowRecurse bool
|
|
}
|
|
|
|
func TestPlanner(t *testing.T) {
|
|
log.SetLevel(log.DebugLevel)
|
|
|
|
tables := []WorkflowPlanTest{
|
|
{"invalid-job-name/invalid-1.yml", "workflow is not valid. 'invalid-job-name-1': Job name 'invalid-JOB-Name-v1.2.3-docker_hub' is invalid. Names must start with a letter or '_' and contain only alphanumeric characters, '-', or '_'", false},
|
|
{"invalid-job-name/invalid-2.yml", "workflow is not valid. 'invalid-job-name-2': Job name '1234invalid-JOB-Name-v123-docker_hub' is invalid. Names must start with a letter or '_' and contain only alphanumeric characters, '-', or '_'", false},
|
|
{"invalid-job-name/valid-1.yml", "", false},
|
|
{"invalid-job-name/valid-2.yml", "", false},
|
|
{"empty-workflow", "unable to read workflow 'push.yml': file is empty: EOF", false},
|
|
{"nested", "unable to read workflow 'fail.yml': file is empty: EOF", false},
|
|
{"nested", "", true},
|
|
}
|
|
|
|
workdir, err := filepath.Abs("testdata")
|
|
assert.NoError(t, err, workdir)
|
|
for _, table := range tables {
|
|
fullWorkflowPath := filepath.Join(workdir, table.workflowPath)
|
|
_, err = NewWorkflowPlanner(fullWorkflowPath, table.noWorkflowRecurse, false)
|
|
if table.errorMessage == "" {
|
|
assert.NoError(t, err, "WorkflowPlanner should exit without any error")
|
|
} else {
|
|
assert.EqualError(t, err, table.errorMessage)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestWorkflow(t *testing.T) {
|
|
log.SetLevel(log.DebugLevel)
|
|
|
|
workflow := Workflow{
|
|
Jobs: map[string]*Job{
|
|
"valid_job": {
|
|
Name: "valid_job",
|
|
},
|
|
},
|
|
}
|
|
|
|
// Check that a valid job id returns non-error
|
|
result, err := createStages(&workflow, "valid_job")
|
|
assert.Nil(t, err)
|
|
assert.NotNil(t, result)
|
|
}
|