mirror of
https://code.forgejo.org/forgejo/runner.git
synced 2025-09-05 18:40:59 +00:00
165b44deec
A job with a `runs-on` that references matrix variables will not run with the expected labels. eg.
```
jobs:
matrix-runs-on:
strategy:
matrix:
os: [ubuntu-latest, ubuntu-20.04]
runs-on: ${{ matrix.os }}
steps:
...
```
Due to shared mutated state, both jobs that this generates will (w/ a race condition) either run with the `ubuntu-latest` or `ubuntu-20.04`, but rarely (never observed) with the expected outcome of running on both labels.
`EvaluateYamlNode` is used to evaluate expressions in the `runs-on` field in the context of the current running job, but mutating an object shared between multiple concurrent jobs (in matrix evaluation). This results in the evaluation results from one job spilling into another and corrupting their `runs-on` labels.
```
==================
WARNING: DATA RACE
Write at 0x00c00047e0b0 by goroutine 1739:
reflect.typedmemmove()
/.../go/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.6.linux-amd64/src/runtime/mbarrier.go:213 +0x0
reflect.Value.Set()
/.../go/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.6.linux-amd64/src/reflect/value.go:2062 +0x184
gopkg.in/yaml%2ev3.(*decoder).unmarshal()
/.../go/pkg/mod/gopkg.in/yaml.v3@v3.0.1/decode.go:493 +0x7b4
gopkg.in/yaml%2ev3.(*Node).Decode()
/.../go/pkg/mod/gopkg.in/yaml.v3@v3.0.1/yaml.go:149 +0x355
code.forgejo.org/forgejo/runner/v9/act/runner.expressionEvaluator.EvaluateYamlNode()
/.../forgejo-runner/act/runner/expression.go:372 +0x7a
code.forgejo.org/forgejo/runner/v9/act/runner.(*expressionEvaluator).EvaluateYamlNode()
<autogenerated>:1 +0x6b
code.forgejo.org/forgejo/runner/v9/act/runner.(*RunContext).runsOnPlatformNames()
/.../forgejo-runner/act/runner/run_context.go:1019 +0x2af
code.forgejo.org/forgejo/runner/v9/act/runner.(*RunContext).runsOnImage()
/.../forgejo-runner/act/runner/run_context.go:1002 +0x772
code.forgejo.org/forgejo/runner/v9/act/runner.(*RunContext).platformImage()
/.../forgejo-runner/act/runner/run_context.go:1032 +0x77
code.forgejo.org/forgejo/runner/v9/act/runner.(*RunContext).isEnabled()
/.../forgejo-runner/act/runner/run_context.go:1069 +0x3c7
code.forgejo.org/forgejo/runner/v9/act/runner.(*RunContext).Executor.func1()
/.../forgejo-runner/act/runner/run_context.go:964 +0x4b
code.forgejo.org/forgejo/runner/v9/act/runner.(*runnerImpl).NewPlanExecutor.func1.1()
/.../forgejo-runner/act/runner/runner.go:223 +0x271
code.forgejo.org/forgejo/runner/v9/act/runner.(*runnerImpl).NewPlanExecutor.func1.NewParallelExecutor.2.1()
/.../forgejo-runner/act/common/executor.go:107 +0x61
code.forgejo.org/forgejo/runner/v9/act/runner.(*runnerImpl).NewPlanExecutor.func1.NewParallelExecutor.2.gowrap1()
/.../forgejo-runner/act/common/executor.go:109 +0x4f
Previous read at 0x00c00047e0b0 by goroutine 1742:
code.forgejo.org/forgejo/runner/v9/act/model.(*Job).RunsOn()
/.../forgejo-runner/act/model/workflow.go:361 +0x3c4
code.forgejo.org/forgejo/runner/v9/act/runner.(*RunContext).runsOnImage()
/.../forgejo-runner/act/runner/run_context.go:991 +0x57a
code.forgejo.org/forgejo/runner/v9/act/runner.(*RunContext).platformImage()
/.../forgejo-runner/act/runner/run_context.go:1032 +0x77
code.forgejo.org/forgejo/runner/v9/act/runner.(*RunContext).isEnabled()
/.../forgejo-runner/act/runner/run_context.go:1069 +0x3c7
code.forgejo.org/forgejo/runner/v9/act/runner.(*RunContext).Executor.func1()
/.../forgejo-runner/act/runner/run_context.go:964 +0x4b
code.forgejo.org/forgejo/runner/v9/act/runner.(*runnerImpl).NewPlanExecutor.func1.1()
/.../forgejo-runner/act/runner/runner.go:223 +0x271
code.forgejo.org/forgejo/runner/v9/act/runner.(*runnerImpl).NewPlanExecutor.func1.NewParallelExecutor.2.1()
/.../forgejo-runner/act/common/executor.go:107 +0x61
code.forgejo.org/forgejo/runner/v9/act/runner.(*runnerImpl).NewPlanExecutor.func1.NewParallelExecutor.2.gowrap1()
/.../forgejo-runner/act/common/executor.go:109 +0x4f
...
==================
```
<!--start release-notes-assistant-->
<!--URL:https://code.forgejo.org/forgejo/runner-->
- bug fixes
- [PR](https://code.forgejo.org/forgejo/runner/pulls/871): <!--number 871 --><!--line 0 --><!--description Zml4OiBkYXRhIHJhY2UgaW4gJ3J1bnMtb24nIGV4cHJlc3Npb25zIGNhdXNlcyBpbmNvcnJlY3Qgam9iIGxhYmVscyBkdXJpbmcgZXhlY3V0aW9u-->fix: data race in 'runs-on' expressions causes incorrect job labels during execution<!--description-->
<!--end release-notes-assistant-->
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/871
Reviewed-by: earl-warren <earl-warren@noreply.code.forgejo.org>
Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net>
Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net>
|
||
|---|---|---|
| .. | ||
| .github/workflows | ||
| act-composite-env-test | ||
| actions | ||
| actions-environment-and-context-tests | ||
| basic | ||
| checkout | ||
| commands | ||
| composite-fail-with-output | ||
| container-hostname | ||
| defaults-run | ||
| dir with spaces | ||
| do-not-leak-step-env-in-composite | ||
| docker-action-custom-path | ||
| ensure-post-steps | ||
| env-and-path | ||
| environment-files | ||
| environment-files-parser-bug | ||
| environment-variables | ||
| evalenv | ||
| evalmatrix | ||
| evalmatrix-merge-array | ||
| evalmatrix-merge-map | ||
| evalmatrixneeds | ||
| evalmatrixneeds2 | ||
| fail | ||
| GITHUB_ENV-use-in-env-ctx | ||
| GITHUB_STATE | ||
| if-env-act | ||
| if-expressions | ||
| input-from-cli | ||
| inputs-via-env-context | ||
| issue-104 | ||
| issue-122 | ||
| issue-141 | ||
| issue-597 | ||
| issue-598 | ||
| issue-1595 | ||
| job-container | ||
| job-container-invalid-credentials | ||
| job-container-non-root | ||
| job-needs-context-contains-result | ||
| job-nil-step | ||
| job-status-check | ||
| local-action-docker-url | ||
| local-action-dockerfile | ||
| local-action-fails-schema-validation | ||
| local-action-js | ||
| local-action-via-composite-dockerfile | ||
| localdockerimagetest_ | ||
| mask-values | ||
| matrix | ||
| matrix-exitcode | ||
| matrix-include-exclude | ||
| matrix-runs-on | ||
| matrix-shell | ||
| matrix-with-user-inclusions | ||
| mysql-service-container-premature-terminate | ||
| mysql-service-container-with-health-check | ||
| networking | ||
| nix-prepend-path | ||
| no-panic-on-invalid-composite-action | ||
| node | ||
| non-existent-action | ||
| outputs | ||
| parallel | ||
| path-handling | ||
| pull-request | ||
| python | ||
| remote-action-composite-action-ref | ||
| remote-action-composite-js-pre-with-defaults | ||
| remote-action-docker | ||
| remote-action-js | ||
| remote-action-js-node-user | ||
| runs-on | ||
| secrets | ||
| services | ||
| services-with-container | ||
| set-env-new-env-file-per-step | ||
| set-env-step-env-override | ||
| shells | ||
| skipjob | ||
| skipstep | ||
| steps-context | ||
| stepsummary | ||
| tool-cache | ||
| uses-action-with-pre-and-post-step | ||
| uses-and-run-in-one-step | ||
| uses-composite | ||
| uses-composite-check-for-input-collision | ||
| uses-composite-check-for-input-in-if-uses | ||
| uses-composite-check-for-input-shadowing | ||
| uses-composite-with-error | ||
| uses-composite-with-inputs | ||
| uses-composite-with-pre-and-post-steps | ||
| uses-docker-url | ||
| uses-github-empty | ||
| uses-github-full-sha | ||
| uses-github-noref | ||
| uses-github-path | ||
| uses-github-root | ||
| uses-github-short-sha | ||
| uses-nested-composite | ||
| uses-sh | ||
| uses-sh-test-action-path | ||
| uses-workflow | ||
| uses-workflow-defaults | ||
| windows-add-env | ||
| windows-prepend-path | ||
| windows-shell-cmd | ||
| workdir | ||
| workflow_call_inputs | ||
| workflow_dispatch | ||
| workflow_dispatch-scalar | ||
| workflow_dispatch-scalar-composite-action | ||
| workflow_dispatch_no_inputs_mapping | ||