mirror of
https://code.forgejo.org/forgejo/runner.git
synced 2025-10-05 19:30:59 +00:00
e1e7d0e85a
The working directory was not cleaned up upon completion of a LXC job because rc.stopJobContainer() -> rc.cleanUpJobContainer() -> rc.JobContainer.Remove() was never called for LXC containers.
- stopContainer() and closeContainer() must not call
rc.stopHostEnvironment(ctx) for LXC containers because
- it will needlessly be called twice
- it intercepts the call to
- rc.stopJobContainer()
- rc.JobContainer.Close()
- rc.stopHostEnvironment(ctx) must be called in rc.cleanUpJobContainer which is indirectly called by rc.stopJobContainer()
- since rc.JobContainer.Close() is a noop, not calling it for LXC containers had no consequence
Resolves forgejo/runner#442
<!--start release-notes-assistant-->
<!--URL:https://code.forgejo.org/forgejo/runner-->
- bug fixes
- [PR](https://code.forgejo.org/forgejo/runner/pulls/1003): <!--number 1003 --><!--line 0 --><!--description Zml4OiByZW1vdmUgTFhDIHdvcmtpbmcgZGlyZWN0b3J5IHdoZW4gaXQgY29tcGxldGVz-->fix: remove LXC working directory when it completes<!--description-->
<!--end release-notes-assistant-->
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/1003
Reviewed-by: Mathieu Fenniak <mfenniak@noreply.code.forgejo.org>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
|
||
|---|---|---|
| .. | ||
| hashfiles | ||
| mocks | ||
| res | ||
| testdata | ||
| action.go | ||
| action_cache.go | ||
| action_cache_offline_mode.go | ||
| action_cache_test.go | ||
| action_composite.go | ||
| action_test.go | ||
| command.go | ||
| command_test.go | ||
| container_mock_test.go | ||
| expression.go | ||
| expression_test.go | ||
| job_executor.go | ||
| job_executor_test.go | ||
| local_repository_cache.go | ||
| logger.go | ||
| lxc-helpers-lib.sh | ||
| lxc-helpers.sh | ||
| reusable_workflow.go | ||
| run_context.go | ||
| run_context_test.go | ||
| runner.go | ||
| runner_test.go | ||
| step.go | ||
| step_action_local.go | ||
| step_action_local_test.go | ||
| step_action_remote.go | ||
| step_action_remote_test.go | ||
| step_docker.go | ||
| step_docker_test.go | ||
| step_factory.go | ||
| step_factory_test.go | ||
| step_run.go | ||
| step_run_test.go | ||
| step_test.go | ||