mirror of
https://code.forgejo.org/forgejo/runner.git
synced 2025-09-05 18:40:59 +00:00
Tests were using `count` and similar variables without any concurrency safety and have been updated to use atomic operations. This may have caused rare miscounts in tests as operations like `count++` are not thread-safe, but to my knowledge these have never been observed. Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/860 Reviewed-by: Gusted <gusted@noreply.code.forgejo.org> Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net> Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net>
164 lines
3.7 KiB
Go
164 lines
3.7 KiB
Go
package common
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"sync/atomic"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestNewWorkflow(t *testing.T) {
|
|
assert := assert.New(t)
|
|
|
|
ctx := t.Context()
|
|
|
|
// empty
|
|
emptyWorkflow := NewPipelineExecutor()
|
|
assert.Nil(emptyWorkflow(ctx))
|
|
|
|
// error case
|
|
errorWorkflow := NewErrorExecutor(fmt.Errorf("test error"))
|
|
assert.NotNil(errorWorkflow(ctx))
|
|
|
|
// multiple success case
|
|
runcount := 0
|
|
successWorkflow := NewPipelineExecutor(
|
|
func(ctx context.Context) error {
|
|
runcount++
|
|
return nil
|
|
},
|
|
func(ctx context.Context) error {
|
|
runcount++
|
|
return nil
|
|
})
|
|
assert.Nil(successWorkflow(ctx))
|
|
assert.Equal(2, runcount)
|
|
}
|
|
|
|
func TestNewConditionalExecutor(t *testing.T) {
|
|
assert := assert.New(t)
|
|
|
|
ctx := t.Context()
|
|
|
|
trueCount := 0
|
|
falseCount := 0
|
|
|
|
err := NewConditionalExecutor(func(ctx context.Context) bool {
|
|
return false
|
|
}, func(ctx context.Context) error {
|
|
trueCount++
|
|
return nil
|
|
}, func(ctx context.Context) error {
|
|
falseCount++
|
|
return nil
|
|
})(ctx)
|
|
|
|
assert.Nil(err)
|
|
assert.Equal(0, trueCount)
|
|
assert.Equal(1, falseCount)
|
|
|
|
err = NewConditionalExecutor(func(ctx context.Context) bool {
|
|
return true
|
|
}, func(ctx context.Context) error {
|
|
trueCount++
|
|
return nil
|
|
}, func(ctx context.Context) error {
|
|
falseCount++
|
|
return nil
|
|
})(ctx)
|
|
|
|
assert.Nil(err)
|
|
assert.Equal(1, trueCount)
|
|
assert.Equal(1, falseCount)
|
|
}
|
|
|
|
func TestNewParallelExecutor(t *testing.T) {
|
|
assert := assert.New(t)
|
|
|
|
ctx := t.Context()
|
|
|
|
var count atomic.Int32
|
|
var activeCount atomic.Int32
|
|
var maxCount atomic.Int32
|
|
|
|
emptyWorkflow := NewPipelineExecutor(func(ctx context.Context) error {
|
|
count.Add(1)
|
|
|
|
currentActive := activeCount.Add(1)
|
|
|
|
// maxCount = max(maxCount, currentActive) -- but concurrent-safe by using CompareAndSwap.
|
|
for {
|
|
currentMax := maxCount.Load()
|
|
if currentActive <= currentMax {
|
|
break
|
|
}
|
|
if maxCount.CompareAndSwap(currentMax, currentActive) {
|
|
break
|
|
}
|
|
// If CompareAndSwap failed, retry due to concurrent update by another goroutine.
|
|
}
|
|
|
|
time.Sleep(2 * time.Second)
|
|
activeCount.Add(-1)
|
|
|
|
return nil
|
|
})
|
|
|
|
err := NewParallelExecutor(2, emptyWorkflow, emptyWorkflow, emptyWorkflow)(ctx)
|
|
|
|
assert.Equal(int32(3), count.Load(), "should run all 3 executors")
|
|
assert.Equal(int32(2), maxCount.Load(), "should run at most 2 executors in parallel")
|
|
assert.Nil(err)
|
|
|
|
// Reset to test running the executor with 0 parallelism
|
|
count.Store(0)
|
|
activeCount.Store(0)
|
|
maxCount.Store(0)
|
|
|
|
errSingle := NewParallelExecutor(0, emptyWorkflow, emptyWorkflow, emptyWorkflow)(ctx)
|
|
|
|
assert.Equal(int32(3), count.Load(), "should run all 3 executors")
|
|
assert.Equal(int32(1), maxCount.Load(), "should run at most 1 executors in parallel")
|
|
assert.Nil(errSingle)
|
|
}
|
|
|
|
func TestNewParallelExecutorFailed(t *testing.T) {
|
|
assert := assert.New(t)
|
|
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
cancel()
|
|
|
|
var count atomic.Int32
|
|
errorWorkflow := NewPipelineExecutor(func(ctx context.Context) error {
|
|
count.Add(1)
|
|
return fmt.Errorf("fake error")
|
|
})
|
|
err := NewParallelExecutor(1, errorWorkflow)(ctx)
|
|
assert.Equal(int32(1), count.Load())
|
|
assert.ErrorIs(context.Canceled, err)
|
|
}
|
|
|
|
func TestNewParallelExecutorCanceled(t *testing.T) {
|
|
assert := assert.New(t)
|
|
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
cancel()
|
|
|
|
errExpected := fmt.Errorf("fake error")
|
|
|
|
var count atomic.Int32
|
|
successWorkflow := NewPipelineExecutor(func(ctx context.Context) error {
|
|
count.Add(1)
|
|
return nil
|
|
})
|
|
errorWorkflow := NewPipelineExecutor(func(ctx context.Context) error {
|
|
count.Add(1)
|
|
return errExpected
|
|
})
|
|
err := NewParallelExecutor(3, errorWorkflow, successWorkflow, successWorkflow)(ctx)
|
|
assert.Equal(int32(3), count.Load())
|
|
assert.Error(errExpected, err)
|
|
}
|