1
0
Fork 0
mirror of https://code.forgejo.org/forgejo/runner.git synced 2025-10-10 19:32:04 +00:00
forgejo-runner/act/runner
Earl Warren ed7dcb0081
fix: a composite action must not change the result of the calling step before it completes (#1019)
Resolves forgejo/runner#1014

---

Manual testing can also be done using the [reproducer from the issue](https://code.forgejo.org/forgejo/runner/issues/1014#issuecomment-60694).

## Before

The first step of the local composite action sets the step result of the job to success which confuses Forgejo display.

![image](/attachments/4f5c9477-47b8-4450-a858-c86312ced946)

## After

Forgejo displays the progress of the composite action in the step calling it.

![image](/attachments/eed08b5d-b590-472f-9140-eced739dd47b)

<!--start release-notes-assistant-->
<!--URL:https://code.forgejo.org/forgejo/runner-->
- bug fixes
  - [PR](https://code.forgejo.org/forgejo/runner/pulls/1019): <!--number 1019 --><!--line 0 --><!--description Zml4OiBhIGNvbXBvc2l0ZSBhY3Rpb24gbXVzdCBub3QgY2hhbmdlIHRoZSByZXN1bHQgb2YgdGhlIGNhbGxpbmcgc3RlcCBiZWZvcmUgaXQgY29tcGxldGVz-->fix: a composite action must not change the result of the calling step before it completes<!--description-->
<!--end release-notes-assistant-->

Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/1019
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Reviewed-by: Mathieu Fenniak <mfenniak@noreply.code.forgejo.org>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2025-09-20 16:30:19 +00:00
..
hashfiles [RDNF #11] fix: skipped jobs have no result & fix: favor command-line over files & chore: fix some comments (#143) 2025-06-09 10:25:43 +00:00
mocks fix: send job outputs & job result to Forgejo in sync with each other (#995) 2025-09-14 20:02:43 +00:00
res Add super-linter + fix lint issues (#650) 2021-05-03 09:52:03 -07:00
testdata fix: enforce job.<job-id>.timeout-minutes (#982) 2025-09-11 14:43:26 +00:00
action.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
action_cache.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
action_cache_offline_mode.go feat: offline mode for new action cache (#2173) 2025-04-12 14:03:12 +00:00
action_cache_test.go test: prevent data race detection in TestActionCache (#858) 2025-08-15 09:00:50 +00:00
action_composite.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
action_test.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
command.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
command_test.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
container_mock_test.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
expression.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
expression_test.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
job_executor.go fix: send job outputs & job result to Forgejo in sync with each other (#995) 2025-09-14 20:02:43 +00:00
job_executor_test.go fix: send job outputs & job result to Forgejo in sync with each other (#995) 2025-09-14 20:02:43 +00:00
local_repository_cache.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
logger.go fix: a composite action must not change the result of the calling step before it completes (#1019) 2025-09-20 16:30:19 +00:00
logger_test.go fix: a composite action must not change the result of the calling step before it completes (#1019) 2025-09-20 16:30:19 +00:00
lxc-helpers-lib.sh feat: add support for a trixie based Debian GNU/Linux backend (e.g. trixie-lxc:lxc://debian:trixie) (#997) 2025-09-15 07:26:56 +00:00
lxc-helpers.sh feat: add support for a trixie based Debian GNU/Linux backend (e.g. trixie-lxc:lxc://debian:trixie) (#997) 2025-09-15 07:26:56 +00:00
reusable_workflow.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
run_context.go fix: remove LXC working directory when it completes (#1003) 2025-09-16 19:42:04 +00:00
run_context_test.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
runner.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
runner_test.go fix: enforce job.<job-id>.timeout-minutes (#982) 2025-09-11 14:43:26 +00:00
step.go fix: enforce job.<job-id>.timeout-minutes (#982) 2025-09-11 14:43:26 +00:00
step_action_local.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
step_action_local_test.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
step_action_remote.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
step_action_remote_test.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
step_docker.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
step_docker_test.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
step_factory.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
step_factory_test.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
step_run.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
step_run_test.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
step_test.go chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00