mirror of
https://code.forgejo.org/forgejo/runner.git
synced 2025-10-20 19:52:06 +00:00
e1e7d0e85a
The working directory was not cleaned up upon completion of a LXC job because rc.stopJobContainer() -> rc.cleanUpJobContainer() -> rc.JobContainer.Remove() was never called for LXC containers.
- stopContainer() and closeContainer() must not call
rc.stopHostEnvironment(ctx) for LXC containers because
- it will needlessly be called twice
- it intercepts the call to
- rc.stopJobContainer()
- rc.JobContainer.Close()
- rc.stopHostEnvironment(ctx) must be called in rc.cleanUpJobContainer which is indirectly called by rc.stopJobContainer()
- since rc.JobContainer.Close() is a noop, not calling it for LXC containers had no consequence
Resolves forgejo/runner#442
<!--start release-notes-assistant-->
<!--URL:https://code.forgejo.org/forgejo/runner-->
- bug fixes
- [PR](https://code.forgejo.org/forgejo/runner/pulls/1003): <!--number 1003 --><!--line 0 --><!--description Zml4OiByZW1vdmUgTFhDIHdvcmtpbmcgZGlyZWN0b3J5IHdoZW4gaXQgY29tcGxldGVz-->fix: remove LXC working directory when it completes<!--description-->
<!--end release-notes-assistant-->
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/1003
Reviewed-by: Mathieu Fenniak <mfenniak@noreply.code.forgejo.org>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
|
||
|---|---|---|
| .. | ||
| testdata | ||
| container_types.go | ||
| docker_auth.go | ||
| docker_build.go | ||
| docker_cli.go | ||
| docker_cli_test.go | ||
| docker_images.go | ||
| docker_images_test.go | ||
| DOCKER_LICENSE | ||
| docker_logger.go | ||
| docker_network.go | ||
| docker_pull.go | ||
| docker_pull_test.go | ||
| docker_run.go | ||
| docker_run_test.go | ||
| docker_stub.go | ||
| docker_volume.go | ||
| executions_environment.go | ||
| host_environment.go | ||
| host_environment_test.go | ||
| linux_container_environment_extensions.go | ||
| linux_container_environment_extensions_test.go | ||
| parse_env_file.go | ||
| util.go | ||
| util_openbsd_mips64.go | ||
| util_plan9.go | ||
| util_windows.go | ||