1
0
Fork 0
mirror of https://code.forgejo.org/forgejo/runner.git synced 2025-09-25 19:17:01 +00:00
forgejo-runner/act
Earl Warren ed7dcb0081
fix: a composite action must not change the result of the calling step before it completes (#1019)
Resolves forgejo/runner#1014

---

Manual testing can also be done using the [reproducer from the issue](https://code.forgejo.org/forgejo/runner/issues/1014#issuecomment-60694).

## Before

The first step of the local composite action sets the step result of the job to success which confuses Forgejo display.

![image](/attachments/4f5c9477-47b8-4450-a858-c86312ced946)

## After

Forgejo displays the progress of the composite action in the step calling it.

![image](/attachments/eed08b5d-b590-472f-9140-eced739dd47b)

<!--start release-notes-assistant-->
<!--URL:https://code.forgejo.org/forgejo/runner-->
- bug fixes
  - [PR](https://code.forgejo.org/forgejo/runner/pulls/1019): <!--number 1019 --><!--line 0 --><!--description Zml4OiBhIGNvbXBvc2l0ZSBhY3Rpb24gbXVzdCBub3QgY2hhbmdlIHRoZSByZXN1bHQgb2YgdGhlIGNhbGxpbmcgc3RlcCBiZWZvcmUgaXQgY29tcGxldGVz-->fix: a composite action must not change the result of the calling step before it completes<!--description-->
<!--end release-notes-assistant-->

Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/1019
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Reviewed-by: Mathieu Fenniak <mfenniak@noreply.code.forgejo.org>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2025-09-20 16:30:19 +00:00
..
artifactcache chore: cache: handler: test coverage for fatal errors 2025-09-05 17:30:08 +02:00
cacheproxy chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
common chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
container fix: remove LXC working directory when it completes (#1003) 2025-09-16 19:42:04 +00:00
exprparser feat: the forgejo context is equivalent to the github context (#999) 2025-09-15 09:14:11 +00:00
filecollector chore: modernize code (#857) 2025-08-15 04:54:13 +00:00
jobparser chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
lookpath chore: use the same .golangci.yml as the runner & gofumpt over gofmt (#206) 2025-07-28 12:26:41 +00:00
model chore: bump version to v11 (#940) 2025-09-05 07:29:38 +00:00
runner fix: a composite action must not change the result of the calling step before it completes (#1019) 2025-09-20 16:30:19 +00:00
schema fix: schema validation must accept aliases and merges (#1012) 2025-09-18 07:19:44 +00:00
workflowpattern chore: modernize code (#857) 2025-08-15 04:54:13 +00:00