Earl Warren
2be7a6f1a5
fix: sanitize network aliases to be valid DNS names ( #190 )
...
- s/[^A-Z0-9-]/_/g
- add a log line in case the name is sanitized
Closes forgejo/runner#226
---
It is breaking because it will fail jobs that rely on service names that contain characters that are sanitized
Reviewed-on: https://code.forgejo.org/forgejo/act/pulls/190
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2025-07-22 07:54:10 +00:00
Earl Warren
4a8d6556c7
chore(cleanup): delete a network scheduled for deletion even if there is no service ( #189 )
...
In the current implementation, the network will only be created and be scheduled to be deleted when there is a service:
```go
func (rc *RunContext) networkName() (string, bool) {
if len(rc.Run.Job().Services) > 0 || rc.Config.ContainerNetworkMode == "" {
return fmt.Sprintf("%s-%s-network", rc.jobContainerName(), rc.Run.JobID), true
}
return string(rc.Config.ContainerNetworkMode), false
}
```
Therefore it does not currently make a difference. However, in case the network creation logic changes and a network is created even if a service is not present, it would be incorrect not to delete it.
Reviewed-on: https://code.forgejo.org/forgejo/act/pulls/189
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2025-07-22 06:08:31 +00:00
earl-warren
a157d24741
feat: use hashed uses string as cache dir name ( #186 )
...
Port of https://gitea.com/gitea/act/pulls/117
Refs forgejo/act#100
Co-authored-by: Jason Song <i@wolfogre.com>
Reviewed-on: https://code.forgejo.org/forgejo/act/pulls/186
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2025-07-21 21:08:46 +00:00
Renovate Bot
5f37fae2dc
Update https://code.forgejo.org/actions/cascading-pr action to v2.2.1 ( #717 )
...
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [https://code.forgejo.org/actions/cascading-pr ](https://code.forgejo.org/actions/cascading-pr ) | action | patch | `v2.2.0` -> `v2.2.1` |
---
### Release Notes
<details>
<summary>actions/cascading-pr (https://code.forgejo.org/actions/cascading-pr )</summary>
### [`v2.2.1`](https://code.forgejo.org/actions/cascading-pr/compare/v2.2.0...v2.2.1 )
[Compare Source](https://code.forgejo.org/actions/cascading-pr/compare/v2.2.0...v2.2.1 )
</details>
---
### Configuration
📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4zMi4xIiwidXBkYXRlZEluVmVyIjoiNDEuMzIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/717
Reviewed-by: earl-warren <earl-warren@noreply.code.forgejo.org>
Co-authored-by: Renovate Bot <bot@kriese.eu>
Co-committed-by: Renovate Bot <bot@kriese.eu>
2025-07-21 07:44:19 +00:00
Earl Warren
51e2962718
chore(docs): reword the documentation of the cache configuration [skip ci] [skip cascade] ( #697 )
...
Refs forgejo/runner#229
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/697
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2025-07-20 22:51:47 +00:00
Earl Warren
9211ded55c
chore(release-notes): warning on overriding FORGEJO_* variables
2025-07-18 06:55:45 +02:00
Renovate Bot
5ca5acd76a
Update module code.forgejo.org/forgejo/act to v1.31.0 ( #714 )
...
This PR contains the following updates:
| Package | Change | Age | Confidence |
|---|---|---|---|
| [code.forgejo.org/forgejo/act](https://code.forgejo.org/forgejo/act ) | `v1.30.0` -> `v1.31.0` | [](https://docs.renovatebot.com/merge-confidence/ ) | [](https://docs.renovatebot.com/merge-confidence/ ) |
---
### Release Notes
<details>
<summary>forgejo/act (code.forgejo.org/forgejo/act)</summary>
### [`v1.31.0`](https://code.forgejo.org/forgejo/act/compare/v1.30.0...v1.31.0 )
[Compare Source](https://code.forgejo.org/forgejo/act/compare/v1.30.0...v1.31.0 )
</details>
---
### Configuration
📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4zMi4xIiwidXBkYXRlZEluVmVyIjoiNDEuMzIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Co-authored-by: Earl Warren <contact@earl-warren.org>
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/714
Reviewed-by: earl-warren <earl-warren@noreply.code.forgejo.org>
Co-authored-by: Renovate Bot <bot@kriese.eu>
Co-committed-by: Renovate Bot <bot@kriese.eu>
2025-07-16 12:53:47 +00:00
Renovate Bot
6c9cc6915e
Update code.forgejo.org/oci/alpine Docker tag to v3.22 ( #712 )
...
This PR contains the following updates:
| Package | Update | Change |
|---|---|---|
| [code.forgejo.org/oci/alpine](https://hub.docker.com/_/alpine ) ([source](https://github.com/alpinelinux/docker-alpine )) | minor | `3.21` -> `3.22` |
---
### Configuration
📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4zMi4xIiwidXBkYXRlZEluVmVyIjoiNDEuMzIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/712
Reviewed-by: earl-warren <earl-warren@noreply.code.forgejo.org>
Co-authored-by: Renovate Bot <bot@kriese.eu>
Co-committed-by: Renovate Bot <bot@kriese.eu>
2025-07-16 09:11:29 +00:00
Earl Warren
13ed94f5b7
feat!: add the validate argument to reading workflows ( #180 )
...
This is a followup of https://code.forgejo.org/forgejo/act/pulls/170 so that it is possible to read a workflow without validation. It is not uncommon for Forgejo to read a workflow just to extract a few information from it, knowing it has been validated before. It would be a performance regression if schema validation happened in these cases.
This is a port of https://github.com/nektos/act/pull/2717/files
It is a breaking change in the context of Forgejo and Forgejo runner because it will need to add the new `validate` argument when reading workflows.
Co-authored-by: ChristopherHX <christopher.homberger@web.de>
Reviewed-on: https://code.forgejo.org/forgejo/act/pulls/180
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2025-07-16 08:46:36 +00:00
Renovate Bot
3c96c9447c
Update Node.js to v22 ( #706 )
...
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [code.forgejo.org/oci/node](https://hub.docker.com/_/node ) ([source](https://github.com/nodejs/docker-node )) | container | major | `20-bookworm` -> `22-bookworm` |
---
### Configuration
📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4zMi4xIiwidXBkYXRlZEluVmVyIjoiNDEuMzIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/706
Co-authored-by: Renovate Bot <bot@kriese.eu>
Co-committed-by: Renovate Bot <bot@kriese.eu>
2025-07-16 08:20:33 +00:00
Renovate Bot
5456a30e14
Update code.forgejo.org/forgejo/runner Docker tag to v7 ( #704 )
...
This PR contains the following updates:
| Package | Update | Change |
|---|---|---|
| [code.forgejo.org/forgejo/runner](https://forgejo.org ) ([source](https://code.forgejo.org/forgejo/runner )) | major | `6.3.1` -> `7.0.0` |
---
### Release Notes
<details>
<summary>forgejo/runner (code.forgejo.org/forgejo/runner)</summary>
### [`v7.0.0`](https://code.forgejo.org/forgejo/runner/blob/HEAD/RELEASE-NOTES.md#700 )
[Compare Source](https://code.forgejo.org/forgejo/runner/compare/v6.4.0...v7.0.0 )
- Breaking change: [forgejo-runner exec --forgejo-instance replaces --gitea-instance](https://code.forgejo.org/forgejo/runner/pulls/652 ).
- [fix a v6.4.0 regression that fail a job when if: false](https://code.forgejo.org/forgejo/runner/issues/660 ).
- [forge.FORGEJO\_\* can be used instead of github.GITHUB\_\*](https://code.forgejo.org/forgejo/act/pulls/171 ), e.g. `forge.FORGEJO_REPOSITORY` is the same as `github.GITHUB_REPOSITORY`. The `GITHUB_*` environment variables are preserved indefinitely for backward compatibiliy with existing workflows and actions.
- [support for forgejo-runner exec --var](https://code.forgejo.org/forgejo/runner/pulls/645 ).
- [do not force WORKING\_DIR in service containers](https://code.forgejo.org/forgejo/runner/issues/304 ).
- [remove the local action cache if the remote has changed](https://code.forgejo.org/forgejo/act/pulls/142 ), e.g. when [DEFAULT\_ACTIONS\_URL](https://forgejo.org/docs/next/admin/config-cheat-sheet/#actions-actions ) is modified in the forgejo configuration.
### [`v6.4.0`](https://code.forgejo.org/forgejo/runner/blob/HEAD/RELEASE-NOTES.md#640 )
[Compare Source](https://code.forgejo.org/forgejo/runner/compare/v6.3.1...v6.4.0 )
**Do not use, it [contains a regression](https://code.forgejo.org/forgejo/runner/issues/660 ) fixed in 7.0.0.**
- [Update code.forgejo.org/forgejo/act](https://code.forgejo.org/forgejo/runner/pulls/571 ) to v1.26.0. This brings [several security updates](https://code.forgejo.org/forgejo/act/compare/v1.25.1...v1.26.0 ), as well as [offline action caching](613090ecd7
).
- [Remove unused x-runner-version header](https://code.forgejo.org/forgejo/runner/pulls/496 ).
- [Upgrade lxc-systemd using a URL instead of a version](https://code.forgejo.org/forgejo/runner/pulls/520 ).
- [Correctly use HTTP proxy if insecure is true](https://code.forgejo.org/forgejo/runner/pulls/535 ).
- [Update golang.org/x/crypto](https://code.forgejo.org/forgejo/runner/pulls/562 ) to a version that is not susceptible to DOS attack.
- [Update golang.org/x/net](https://code.forgejo.org/forgejo/runner/pulls/563 ) to a version with several security fixes.
</details>
---
### Configuration
📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4zMi4xIiwidXBkYXRlZEluVmVyIjoiNDEuMzIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/704
Reviewed-by: earl-warren <earl-warren@noreply.code.forgejo.org>
Co-authored-by: Renovate Bot <bot@kriese.eu>
Co-committed-by: Renovate Bot <bot@kriese.eu>
2025-07-16 08:01:17 +00:00
Renovate Bot
2e8fbad641
Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 ( #705 )
...
This PR contains the following updates:
| Package | Change | Age | Confidence |
|---|---|---|---|
| [github.com/golangci/golangci-lint/cmd/golangci-lint](https://github.com/golangci/golangci-lint ) | `v1.64.8` -> `v2.2.2` | [](https://docs.renovatebot.com/merge-confidence/ ) | [](https://docs.renovatebot.com/merge-confidence/ ) |
---
### Release Notes
<details>
<summary>golangci/golangci-lint (github.com/golangci/golangci-lint/cmd/golangci-lint)</summary>
### [`v2.2.2`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v222 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.2.1...v2.2.2 )
1. Linters bug fixes
- `noinlineerr`: from 1.0.3 to 1.0.4
2. Documentation
- Improve debug keys documentation
3. Misc.
- fix: panic close of closed channel
- godot: add noinline value into the JSONSchema
### [`v2.2.1`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v221 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.2.0...v2.2.1 )
1. Linters bug fixes
- `varnamelen`: fix configuration
### [`v2.2.0`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v220 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.1.6...v2.2.0 )
1. New linters
- Add `arangolint` linter https://github.com/Crocmagnon/arangolint
- Add `embeddedstructfieldcheck` linter https://github.com/manuelarte/embeddedstructfieldcheck
- Add `noinlineerr` linter https://github.com/AlwxSin/noinlineerr
- Add `swaggo` formatter https://github.com/golangci/swaggoswag
2. Linters new features or changes
- `errcheck`: add `verbose` option
- `funcorder`: from 0.2.1 to 0.5.0 (new option `alphabetical`)
- `gomoddirectives`: from 0.6.1 to 0.7.0 (new option `ignore-forbidden`)
- `iface`: from 1.3.1 to 1.4.0 (new option `unexported`)
- `noctx`: from 0.1.0 to 0.3.3 (new report messages, and new rules related to `database/sql`)
- `noctx`: from 0.3.3 to 0.3.4 (new SQL functions detection)
- `revive`: from 1.9.0 to 1.10.0 (new rules: `time-date`, `unnecessary-format`, `use-fmt-print`)
- `usestdlibvars`: from 1.28.0 to 1.29.0 (new option `time-date-month`)
- `wsl`: deprecation
- `wsl_v5`: from 4.7.0 to 5.0.0 (major version with new configuration)
3. Linters bug fixes
- `dupword`: from 0.1.3 to 0.1.6
- `exptostd`: from 0.4.3 to 0.4.4
- `forbidigo`: from 1.6.0 to 2.1.0
- `gci`: consistently format the code
- `go-spancheck`: from 0.6.4 to 0.6.5
- `goconst`: from 1.8.1 to 1.8.2
- `gosec`: from 2.22.3 to 2.22.4
- `gosec`: from 2.22.4 to 2.22.5
- `makezero`: from 1.2.0 to 2.0.1
- `misspell`: from 0.6.0 to 0.7.0
- `usetesting`: from 0.4.3 to 0.5.0
4. Misc.
- exclusions: fix `path-expect`
- formatters: write the input to `stdout` when using `stdin` and there are no changes
- migration: improve the error message when trying to migrate a migrated config
- `typecheck`: deduplicate errors
- `typecheck`: stops the analysis after the first error
- Deprecate `print-resources-usage` flag
- Unique version per custom build
5. Documentation
- Improves typecheck FAQ
- Adds plugin systems recommendations
- Add description for `linters.default` sets
### [`v2.1.6`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v216 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.1.5...v2.1.6 )
1. Linters bug fixes
- `godot`: from 1.5.0 to 1.5.1
- `musttag`: from 0.13.0 to 0.13.1
2. Documentation
- Add note about golangci-lint v2 integration in VS Code
### [`v2.1.5`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v215 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.1.4...v2.1.5 )
Due to an error related to Snapcraft, some artifacts of the v2.1.4 release have not been published.
This release contains the same things as v2.1.3.
### [`v2.1.4`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v214 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.1.3...v2.1.4 )
Due to an error related to Snapcraft, some artifacts of the v2.1.3 release have not been published.
This release contains the same things as v2.1.3.
### [`v2.1.3`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v213 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.1.2...v2.1.3 )
1. Linters bug fixes
- `fatcontext`: from 0.7.2 to 0.8.0
2. Misc.
- migration: fix `nakedret.max-func-lines: 0`
- migration: fix order of `staticcheck` settings
- fix: add `go.mod` hash to the cache salt
- fix: use diagnostic position for related information position
### [`v2.1.2`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v212 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.1.1...v2.1.2 )
1. Linters bug fixes
- `exptostd`: from 0.4.2 to 0.4.3
- `gofumpt`: from 0.7.0 to 0.8.0
- `protogetter`: from 0.3.13 to 0.3.15
- `usetesting`: from 0.4.2 to 0.4.3
### [`v2.1.1`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v211 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.1.0...v2.1.1 )
The release process of v2.1.0 failed due to a regression inside goreleaser.
The binaries of v2.1.0 have been published, but not the other artifacts (AUR, Docker, etc.).
### [`v2.1.0`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v210 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.0.2...v2.1.0 )
1. Enhancements
- Add an option to display absolute paths (`--path-mode=abs`)
- Add configuration path placeholder (`${config-path}`)
- Add `warn-unused` option for `fmt` command
- Colored diff for `fmt` command (`golangci-lint fmt --diff-colored`)
2. New linters
- Add `funcorder` linter https://github.com/manuelarte/funcorder
3. Linters new features or changes
- `go-errorlint`: from 1.7.1 to 1.8.0 (automatic error comparison and type assertion fixes)
- ⚠️ `goconst`: `ignore-strings` is deprecated and replaced by `ignore-string-values`
- `goconst`: from 1.7.1 to 1.8.1 (new options: `find-duplicates`, `eval-const-expressions`)
- `govet`: add `httpmux` analyzer
- `nilnesserr`: from 0.1.2 to 0.2.0 (detect more cases)
- `paralleltest`: from 1.0.10 to 1.0.14 (checks only `_test.go` files)
- `revive`: from 1.7.0 to 1.9.0 (support kebab case for setting names)
- `sloglint`: from 0.9.0 to 0.11.0 (autofix, new option `msg-style`, suggest `slog.DiscardHandler`)
- `wrapcheck`: from 2.10.0 to 2.11.0 (new option `report-internal-errors`)
- `wsl`: from 4.6.0 to 4.7.0 (cgo files are always excluded)
4. Linters bug fixes
- `fatcontext`: from 0.7.1 to 0.7.2
- `gocritic`: fix `importshadow` checker
- `gosec`: from 2.22.2 to 2.22.3
- `ireturn`: from 0.3.1 to 0.4.0
- `loggercheck`: from 0.10.1 to 0.11.0
- `nakedret`: from 2.0.5 to 2.0.6
- `nonamedreturns`: from 1.0.5 to 1.0.6
- `protogetter`: from 0.3.12 to 0.3.13
- `testifylint`: from 1.6.0 to 1.6.1
- `unconvert`: update to HEAD
5. Misc.
- Fixes memory leaks when using go1.(N) with golangci-lint built with go1.(N-X)
- Adds `golangci-lint-fmt` pre-commit hook
6. Documentation
- Improvements
- Updates section about vscode integration
### [`v2.0.2`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v202 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.0.1...v2.0.2 )
1. Misc.
- Fixes flags parsing for formatters
- Fixes the filepath used by the exclusion `source` option
2. Documentation
- Adds a section about flags migration
- Cleaning pages with v1 options
### [`v2.0.1`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v201 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.0.0...v2.0.1 )
1. Linters/formatters bug fixes
- `golines`: fix settings during linter load
2. Misc.
- Validates the `version` field before the configuration
- `forbidigo`: fix migration
### [`v2.0.0`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v200 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.64.8...v2.0.0 )
1. Enhancements
- 🌟 New `golangci-lint fmt` command with dedicated [formatter configuration](https://golangci-lint.run/welcome/quick-start/#formatting )
- ♻️ New `golangci-lint migrate` command to help migration from v1 to v2 (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#command-migrate ))
- ⚠️ New default values (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/ ))
- ⚠️ No exclusions by default (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#issuesexclude-use-default ))
- ⚠️ New default sort order (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#outputsort-order ))
- 🌟 New option `run.relative-path-mode` (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#runrelative-path-mode ))
- 🌟 New linters configuration (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#linters ))
- 🌟 New output format configuration (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#output ))
- 🌟 New `--fast-only` flag (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#lintersfast ))
- 🌟 New option `linters.exclusions.warn-unused` to log a warning if an exclusion rule is unused.
2. New linters/formatters
- Add `golines` formatter https://github.com/segmentio/golines
3. Linters new features
- ⚠️ Merge `staticcheck`, `stylecheck`, `gosimple` into one linter (`staticcheck`) (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#lintersenablestylecheckgosimplestaticcheck ))
- `go-critic`: from 0.12.0 to 0.13.0
- `gomodguard`: from 1.3.5 to 1.4.1 (block explicit indirect dependencies)
- `nilnil`: from 1.0.1 to 1.1.0 (new option: `only-two`)
- `perfsprint`: from 0.8.2 to 0.9.1 (checker name in the diagnostic message)
- `staticcheck`: new `quickfix` set of rules
- `testifylint`: from 1.5.2 to 1.6.0 (new options: `equal-values`, `suite-method-signature`, `require-string-msg`)
- `wsl`: from 4.5.0 to 4.6.0 (new option: `allow-cuddle-used-in-block`)
4. Linters bug fixes
- `bidichk`: from 0.3.2 to 0.3.3
- `errchkjson`: from 0.4.0 to 0.4.1
- `errname`: from 1.0.0 to 1.1.0
- `funlen`: fix `ignore-comments` option
- `gci`: from 0.13.5 to 0.13.6
- `gosmopolitan`: from 1.2.2 to 1.3.0
- `inamedparam`: from 0.1.3 to 0.2.0
- `intrange`: from 0.3.0 to 0.3.1
- `protogetter`: from 0.3.9 to 0.3.12
- `unparam`: from [`8a5130c`](8a5130ca72
) to [`0df0534`](0df0534333
)
5. Misc.
- 🧹 Configuration options renaming (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/ ))
- 🧹 Remove options (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/ ))
- 🧹 Remove flags (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/ ))
- 🧹 Remove alternative names (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#alternative-linter-names ))
- 🧹 Remove or replace deprecated elements (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/ ))
- Adds an option to display some commands as JSON:
- `golangci-lint config path --json`
- `golangci-lint help linters --json`
- `golangci-lint help formatters --json`
- `golangci-lint linters --json`
- `golangci-lint formatters --json`
- `golangci-lint version --json`
6. Documentation
- [Migration guide](https://golangci-lint.run/product/migration-guide/ )
</details>
---
### Configuration
📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4zMi4xIiwidXBkYXRlZEluVmVyIjoiNDEuMzIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Co-authored-by: Earl Warren <contact@earl-warren.org>
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/705
Reviewed-by: earl-warren <earl-warren@noreply.code.forgejo.org>
Co-authored-by: Renovate Bot <bot@kriese.eu>
Co-committed-by: Renovate Bot <bot@kriese.eu>
2025-07-16 07:51:04 +00:00
Renovate Bot
a978a5ecc1
Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 [skip cascade] ( #185 )
...
This PR contains the following updates:
| Package | Change | Age | Confidence |
|---|---|---|---|
| [github.com/golangci/golangci-lint/cmd/golangci-lint](https://github.com/golangci/golangci-lint ) | `v1.62.2` -> `v2.2.2` | [](https://docs.renovatebot.com/merge-confidence/ ) | [](https://docs.renovatebot.com/merge-confidence/ ) |
---
### Release Notes
<details>
<summary>golangci/golangci-lint (github.com/golangci/golangci-lint/cmd/golangci-lint)</summary>
### [`v2.2.2`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v222 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.2.1...v2.2.2 )
1. Linters bug fixes
- `noinlineerr`: from 1.0.3 to 1.0.4
2. Documentation
- Improve debug keys documentation
3. Misc.
- fix: panic close of closed channel
- godot: add noinline value into the JSONSchema
### [`v2.2.1`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v221 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.2.0...v2.2.1 )
1. Linters bug fixes
- `varnamelen`: fix configuration
### [`v2.2.0`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v220 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.1.6...v2.2.0 )
1. New linters
- Add `arangolint` linter https://github.com/Crocmagnon/arangolint
- Add `embeddedstructfieldcheck` linter https://github.com/manuelarte/embeddedstructfieldcheck
- Add `noinlineerr` linter https://github.com/AlwxSin/noinlineerr
- Add `swaggo` formatter https://github.com/golangci/swaggoswag
2. Linters new features or changes
- `errcheck`: add `verbose` option
- `funcorder`: from 0.2.1 to 0.5.0 (new option `alphabetical`)
- `gomoddirectives`: from 0.6.1 to 0.7.0 (new option `ignore-forbidden`)
- `iface`: from 1.3.1 to 1.4.0 (new option `unexported`)
- `noctx`: from 0.1.0 to 0.3.3 (new report messages, and new rules related to `database/sql`)
- `noctx`: from 0.3.3 to 0.3.4 (new SQL functions detection)
- `revive`: from 1.9.0 to 1.10.0 (new rules: `time-date`, `unnecessary-format`, `use-fmt-print`)
- `usestdlibvars`: from 1.28.0 to 1.29.0 (new option `time-date-month`)
- `wsl`: deprecation
- `wsl_v5`: from 4.7.0 to 5.0.0 (major version with new configuration)
3. Linters bug fixes
- `dupword`: from 0.1.3 to 0.1.6
- `exptostd`: from 0.4.3 to 0.4.4
- `forbidigo`: from 1.6.0 to 2.1.0
- `gci`: consistently format the code
- `go-spancheck`: from 0.6.4 to 0.6.5
- `goconst`: from 1.8.1 to 1.8.2
- `gosec`: from 2.22.3 to 2.22.4
- `gosec`: from 2.22.4 to 2.22.5
- `makezero`: from 1.2.0 to 2.0.1
- `misspell`: from 0.6.0 to 0.7.0
- `usetesting`: from 0.4.3 to 0.5.0
4. Misc.
- exclusions: fix `path-expect`
- formatters: write the input to `stdout` when using `stdin` and there are no changes
- migration: improve the error message when trying to migrate a migrated config
- `typecheck`: deduplicate errors
- `typecheck`: stops the analysis after the first error
- Deprecate `print-resources-usage` flag
- Unique version per custom build
5. Documentation
- Improves typecheck FAQ
- Adds plugin systems recommendations
- Add description for `linters.default` sets
### [`v2.1.6`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v216 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.1.5...v2.1.6 )
1. Linters bug fixes
- `godot`: from 1.5.0 to 1.5.1
- `musttag`: from 0.13.0 to 0.13.1
2. Documentation
- Add note about golangci-lint v2 integration in VS Code
### [`v2.1.5`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v215 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.1.4...v2.1.5 )
Due to an error related to Snapcraft, some artifacts of the v2.1.4 release have not been published.
This release contains the same things as v2.1.3.
### [`v2.1.4`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v214 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.1.3...v2.1.4 )
Due to an error related to Snapcraft, some artifacts of the v2.1.3 release have not been published.
This release contains the same things as v2.1.3.
### [`v2.1.3`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v213 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.1.2...v2.1.3 )
1. Linters bug fixes
- `fatcontext`: from 0.7.2 to 0.8.0
2. Misc.
- migration: fix `nakedret.max-func-lines: 0`
- migration: fix order of `staticcheck` settings
- fix: add `go.mod` hash to the cache salt
- fix: use diagnostic position for related information position
### [`v2.1.2`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v212 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.1.1...v2.1.2 )
1. Linters bug fixes
- `exptostd`: from 0.4.2 to 0.4.3
- `gofumpt`: from 0.7.0 to 0.8.0
- `protogetter`: from 0.3.13 to 0.3.15
- `usetesting`: from 0.4.2 to 0.4.3
### [`v2.1.1`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v211 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.1.0...v2.1.1 )
The release process of v2.1.0 failed due to a regression inside goreleaser.
The binaries of v2.1.0 have been published, but not the other artifacts (AUR, Docker, etc.).
### [`v2.1.0`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v210 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.0.2...v2.1.0 )
1. Enhancements
- Add an option to display absolute paths (`--path-mode=abs`)
- Add configuration path placeholder (`${config-path}`)
- Add `warn-unused` option for `fmt` command
- Colored diff for `fmt` command (`golangci-lint fmt --diff-colored`)
2. New linters
- Add `funcorder` linter https://github.com/manuelarte/funcorder
3. Linters new features or changes
- `go-errorlint`: from 1.7.1 to 1.8.0 (automatic error comparison and type assertion fixes)
- ⚠️ `goconst`: `ignore-strings` is deprecated and replaced by `ignore-string-values`
- `goconst`: from 1.7.1 to 1.8.1 (new options: `find-duplicates`, `eval-const-expressions`)
- `govet`: add `httpmux` analyzer
- `nilnesserr`: from 0.1.2 to 0.2.0 (detect more cases)
- `paralleltest`: from 1.0.10 to 1.0.14 (checks only `_test.go` files)
- `revive`: from 1.7.0 to 1.9.0 (support kebab case for setting names)
- `sloglint`: from 0.9.0 to 0.11.0 (autofix, new option `msg-style`, suggest `slog.DiscardHandler`)
- `wrapcheck`: from 2.10.0 to 2.11.0 (new option `report-internal-errors`)
- `wsl`: from 4.6.0 to 4.7.0 (cgo files are always excluded)
4. Linters bug fixes
- `fatcontext`: from 0.7.1 to 0.7.2
- `gocritic`: fix `importshadow` checker
- `gosec`: from 2.22.2 to 2.22.3
- `ireturn`: from 0.3.1 to 0.4.0
- `loggercheck`: from 0.10.1 to 0.11.0
- `nakedret`: from 2.0.5 to 2.0.6
- `nonamedreturns`: from 1.0.5 to 1.0.6
- `protogetter`: from 0.3.12 to 0.3.13
- `testifylint`: from 1.6.0 to 1.6.1
- `unconvert`: update to HEAD
5. Misc.
- Fixes memory leaks when using go1.(N) with golangci-lint built with go1.(N-X)
- Adds `golangci-lint-fmt` pre-commit hook
6. Documentation
- Improvements
- Updates section about vscode integration
### [`v2.0.2`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v202 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.0.1...v2.0.2 )
1. Misc.
- Fixes flags parsing for formatters
- Fixes the filepath used by the exclusion `source` option
2. Documentation
- Adds a section about flags migration
- Cleaning pages with v1 options
### [`v2.0.1`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v201 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v2.0.0...v2.0.1 )
1. Linters/formatters bug fixes
- `golines`: fix settings during linter load
2. Misc.
- Validates the `version` field before the configuration
- `forbidigo`: fix migration
### [`v2.0.0`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v200 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.64.8...v2.0.0 )
1. Enhancements
- 🌟 New `golangci-lint fmt` command with dedicated [formatter configuration](https://golangci-lint.run/welcome/quick-start/#formatting )
- ♻️ New `golangci-lint migrate` command to help migration from v1 to v2 (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#command-migrate ))
- ⚠️ New default values (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/ ))
- ⚠️ No exclusions by default (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#issuesexclude-use-default ))
- ⚠️ New default sort order (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#outputsort-order ))
- 🌟 New option `run.relative-path-mode` (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#runrelative-path-mode ))
- 🌟 New linters configuration (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#linters ))
- 🌟 New output format configuration (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#output ))
- 🌟 New `--fast-only` flag (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#lintersfast ))
- 🌟 New option `linters.exclusions.warn-unused` to log a warning if an exclusion rule is unused.
2. New linters/formatters
- Add `golines` formatter https://github.com/segmentio/golines
3. Linters new features
- ⚠️ Merge `staticcheck`, `stylecheck`, `gosimple` into one linter (`staticcheck`) (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#lintersenablestylecheckgosimplestaticcheck ))
- `go-critic`: from 0.12.0 to 0.13.0
- `gomodguard`: from 1.3.5 to 1.4.1 (block explicit indirect dependencies)
- `nilnil`: from 1.0.1 to 1.1.0 (new option: `only-two`)
- `perfsprint`: from 0.8.2 to 0.9.1 (checker name in the diagnostic message)
- `staticcheck`: new `quickfix` set of rules
- `testifylint`: from 1.5.2 to 1.6.0 (new options: `equal-values`, `suite-method-signature`, `require-string-msg`)
- `wsl`: from 4.5.0 to 4.6.0 (new option: `allow-cuddle-used-in-block`)
4. Linters bug fixes
- `bidichk`: from 0.3.2 to 0.3.3
- `errchkjson`: from 0.4.0 to 0.4.1
- `errname`: from 1.0.0 to 1.1.0
- `funlen`: fix `ignore-comments` option
- `gci`: from 0.13.5 to 0.13.6
- `gosmopolitan`: from 1.2.2 to 1.3.0
- `inamedparam`: from 0.1.3 to 0.2.0
- `intrange`: from 0.3.0 to 0.3.1
- `protogetter`: from 0.3.9 to 0.3.12
- `unparam`: from [`8a5130c`](8a5130ca72
) to [`0df0534`](0df0534333
)
5. Misc.
- 🧹 Configuration options renaming (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/ ))
- 🧹 Remove options (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/ ))
- 🧹 Remove flags (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/ ))
- 🧹 Remove alternative names (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/#alternative-linter-names ))
- 🧹 Remove or replace deprecated elements (cf. [Migration guide](https://golangci-lint.run/product/migration-guide/ ))
- Adds an option to display some commands as JSON:
- `golangci-lint config path --json`
- `golangci-lint help linters --json`
- `golangci-lint help formatters --json`
- `golangci-lint linters --json`
- `golangci-lint formatters --json`
- `golangci-lint version --json`
6. Documentation
- [Migration guide](https://golangci-lint.run/product/migration-guide/ )
### [`v1.64.8`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1648 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.64.7...v1.64.8 )
- Detects use of configuration files from golangci-lint v2
### [`v1.64.7`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1647 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.64.6...v1.64.7 )
1. Linters bug fixes
- `depguard`: from 2.2.0 to 2.2.1
- `dupl`: from [`3e9179a`](3e9179ac44
) to [`f665c8d`](f665c8d69b
)
- `gosec`: from 2.22.1 to 2.22.2
- `staticcheck`: from 0.6.0 to 0.6.1
2. Documentation
- Add GitLab documentation
### [`v1.64.6`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1646 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.64.5...v1.64.6 )
1. Linters bug fixes
- `asciicheck`: from 0.4.0 to 0.4.1
- `contextcheck`: from 1.1.5 to 1.1.6
- `errcheck`: from 1.8.0 to 1.9.0
- `exptostd`: from 0.4.1 to 0.4.2
- `ginkgolinter`: from 0.19.0 to 0.19.1
- `go-exhaustruct`: from 3.3.0 to 3.3.1
- `gocheckcompilerdirectives`: from 1.2.1 to 1.3.0
- `godot`: from 1.4.20 to 1.5.0
- `perfsprint`: from 0.8.1 to 0.8.2
- `revive`: from 1.6.1 to 1.7.0
- `tagalign`: from 1.4.1 to 1.4.2
### [`v1.64.5`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1645 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.64.4...v1.64.5 )
1. Bug fixes
- Add missing flag `new-from-merge-base-flag`
2. Linters bug fixes
- `asciicheck`: from 0.3.0 to 0.4.0
- `forcetypeassert`: from 0.1.0 to 0.2.0
- `gosec`: from 2.22.0 to 2.22.1
### [`v1.64.4`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1644 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.64.3...v1.64.4 )
1. Linters bug fixes
- `gci`: fix standard packages list for go1.24
### [`v1.64.3`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1643 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.64.2...v1.64.3 )
1. Linters bug fixes
- `ginkgolinter`: from 0.18.4 to 0.19.0
- `go-critic`: from 0.11.5 to 0.12.0
- `revive`: from 1.6.0 to 1.6.1
- `gci`: fix standard packages list for go1.24
2. Misc.
- Build Docker images with go1.24
### [`v1.64.2`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1642 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.64.1...v1.64.2 )
This is the last minor release of golangci-lint v1.
The next release will be golangci-lint [v2](https://github.com/golangci/golangci-lint/issues/5300 ).
1. Enhancements
- 🎉 go1.24 support
- New `issues.new-from-merge-base` option
- New `run.relative-path-mode` option
2. Linters new features
- `copyloopvar`: from 1.1.0 to 1.2.1 (support suggested fixes)
- `exptostd`: from 0.3.1 to 0.4.1 (handles `golang.org/x/exp/constraints.Ordered`)
- `fatcontext`: from 0.5.3 to 0.7.1 (new option: `check-struct-pointers`)
- `perfsprint`: from 0.7.1 to 0.8.1 (new options: `integer-format`, `error-format`, `string-format`, `bool-format`, and `hex-format`)
- `revive`: from 1.5.1 to 1.6.0 (new rules: `redundant-build-tag`, `use-errors-new`. New option `early-return.early-return`)
3. Linters bug fixes
- `go-errorlint`: from 1.7.0 to 1.7.1
- `gochecknoglobals`: from 0.2.1 to 0.2.2
- `godox`: from [`006bad1`](006bad1f9d
) to 1.1.0
- `gosec`: from 2.21.4 to 2.22.0
- `iface`: from 1.3.0 to 1.3.1
- `nilnesserr`: from 0.1.1 to 0.1.2
- `protogetter`: from 0.3.8 to 0.3.9
- `sloglint`: from 0.7.2 to 0.9.0
- `spancheck`: fix default `StartSpanMatchersSlice` values
- `staticcheck`: from 0.5.1 to 0.6.0
4. Deprecations
- ⚠️ `tenv` is deprecated and replaced by `usetesting.os-setenv: true`.
- ⚠️ `exportloopref` deprecation step 2
5. Misc.
- Sanitize severities by output format
- Avoid panic with plugin without description
6. Documentation
- Clarify `depguard` configuration
### [`v1.64.1`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1641 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.64.0...v1.64.1 )
Cancelled due to CI failure.
### [`v1.64.0`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1640 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.63.4...v1.64.0 )
Cancelled due to CI failure.
### [`v1.63.4`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1634 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.63.3...v1.63.4 )
1. Linters bug fixes
- `dupl`, `gomodguard`, `revive`: keep only Go-files.
### [`v1.63.3`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1633 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.63.2...v1.63.3 )
1. Linters bug fixes
- `gofmt`, `gofumpt`, `goimports`, `gci`: panic with several trailing EOL
- `goheader`: skip issues with invalid positions
### [`v1.63.2`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1632 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.63.1...v1.63.2 )
1. Linters bug fixes
- `gofmt`, `gofumpt`, `goimports`, `gci`: panic with missing trailing EOL
### [`v1.63.1`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1631 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.63.0...v1.63.1 )
1. Linters bug fixes
- `cgi`: invalid reports with cgo
- `gofumpt`: panic with autofix and cgo
### [`v1.63.0`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1630 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.62.2...v1.63.0 )
1. Enhancements
- Add support for SuggestedFixes 🎉 (35 linters can "autofix" reports).
- Formatters (`gofmt`, `goimports`, `gofumpt`, `gci`) are applied after the suggested fixes.
2. New linters
- Add `exptostd` linter https://github.com/ldez/exptostd
- Add `nilnesserr` linter https://github.com/alingse/nilnesserr
- Add `usetesting` linter https://github.com/ldez/usetesting
3. Linters new features
- `gci`: new options: `no-inline-comments`, `no-prefix-comments`
- `gomoddirectives`: from 0.2.4 to 0.6.0 (new options: `go-version-pattern`, `toolchain-pattern`,`toolchain-forbidden`, `tool-forbidden`, `go-debug-forbidden`)
- `govet`: new `stdversion`, `waitgroup` analyzers
- `importas`: allow multiple empty aliases
- `loggercheck`: new `slog` option
- `recvcheck`: from 0.1.2 to 0.2.0 (new options: `disable-builtin`, `exclusions`)
- `tagliatelle`: from 0.5.0 to 0.7.1 (new options: `ignored-fields`, `extended-rules`,`overrides`, `pkg`, `ignore`)
- `usestdlibvars`: from 1.27.0 to 1.28.0 (autofix)
- `wrapcheck`: from 2.9.0 to 2.10.0 (new option: `extra-ignore-sigs`)
4. Linters bug fixes
- `asciicheck`: from 0.2.0 to 0.3.0
- `bodyclose`: from [`5742072`](5742072509
) to [`ed6a65f`](ed6a65f985
)
- `funlen`: from 0.1.0 to 0.2.0
- `ginkgolinter`: from 0.18.3 to 0.18.4
- `gochecksumtype`: from 0.2.0 to 0.3.1
- `gocognit`: from 1.1.3 to 1.2.0
- `godot`: from 1.4.18 to 1.4.20
- `goheader`: report position improvement
- `gosec`: handling of global nosec option when it is false
- `iface`: from 1.2.1 to 1.3.0
- `importas`: from 0.1.0 to 0.2.0
- `intrange`: from 0.2.1 to 0.3.0
- `makezero`: from 1.1.1 to 1.2.0
- `mirror`: from 1.2.0 to 1.3.0
- `nilnil`: from 1.0.0 to 1.0.1
- `nosprintfhostport`: from 0.1.1 to 0.2.0
- `reassign`: from 0.2.0 to 0.3.0
- `spancheck`: from 0.6.2 to 0.6.4
- `tagalign`: from 1.3.4 to 1.4.1
- `wastedassign`: from 2.0.7 to 2.1.0
- `whitespace`: from 0.1.1 to 0.2.0
- `wsl`: from 4.4.1 to 4.5.0
5. Deprecations
- ⚠️ `output.uniq-by-line` is deprecated and replaced by `issues.uniq-by-line`.
6. Misc.
- Improvements of the help command (color and JSON support).
- Removes `decoder`, `sloglint`, `tagalign` from `format` preset.
- Enables paths with junction inside Windows.
- The timeout is disabled if `run.timeout` <= 0.
</details>
---
### Configuration
📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4zMi4xIiwidXBkYXRlZEluVmVyIjoiNDEuMzIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Co-authored-by: Earl Warren <contact@earl-warren.org>
Reviewed-on: https://code.forgejo.org/forgejo/act/pulls/185
Reviewed-by: earl-warren <earl-warren@noreply.code.forgejo.org>
Co-authored-by: Renovate Bot <bot@kriese.eu>
Co-committed-by: Renovate Bot <bot@kriese.eu>
2025-07-16 06:52:51 +00:00
Earl Warren
9f94da307d
chore(cleanup): ACT cli is redundant with Forgejo runner cli ( #182 )
...
it is not used in the context of forgejo and is mistaken sometimes for being supported.
Reviewed-on: https://code.forgejo.org/forgejo/act/pulls/182
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2025-07-16 06:15:06 +00:00
Earl Warren
09f7f052b4
chore(renovate): do not exclude examples [skip ci] [skip cascade] ( #699 )
...
https://docs.renovatebot.com/presets-default/#ignoremodulesandtests
Closes forgejo/runner#405
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/699
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2025-07-15 21:31:02 +00:00
Earl Warren
c2f91f63df
fix: image credentials for services must not override container image credentials ( #181 )
...
- do not override username and password when looping over services
- split prepareJobContainer out of startJobContainer
- split getNetworkName out as it is used by both
- add unit tests for prepareJobContainer
- make containre.NewContainer mockable
- add MockVariable helper
Closes forgejo/runner#575
---
Note to reviewers: do not show whitespace change, the refactor will show in a minimal way. When the fix is reverted the tests fail as follows:
```
Diff:
--- Expected
+++ Actual
@@ -81,4 +81,4 @@
Image: (string) (len=10) "some:image",
- Username: (string) (len=17) "containerusername",
- Password: (string) (len=17) "containerpassword",
+ Username: (string) (len=16) "service2username",
+ Password: (string) (len=16) "service2password",
Entrypoint: ([]string) (len=3) {
Test: TestStartJobContainer/Overlapping
```
Reviewed-on: https://code.forgejo.org/forgejo/act/pulls/181
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2025-07-15 20:55:38 +00:00
Earl Warren
87d8366311
chore(tests): reporter.SetOutputs tests have side effects [skip cascade] ( #701 )
...
testutils.MockVariable must be in a defer to restore the previous value.
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/701
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2025-07-15 20:23:38 +00:00
Earl Warren
6e6ebbc981
fix: explain why a workflow cannot be used to run a job ( #666 )
...
- report back to the Forgejo instance
- log Forgejo runner side in debug mode
- display the workflow with line number to facilitate matching with errors
- split the error into multiple lines if possible

Refs forgejo/act#170
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/666
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2025-07-14 20:46:51 +00:00
Renovate Bot
d23b354cbc
Update module code.forgejo.org/forgejo/act to v1.30.0 ( #695 )
...
This PR contains the following updates:
| Package | Change | Age | Confidence |
|---|---|---|---|
| [code.forgejo.org/forgejo/act](https://code.forgejo.org/forgejo/act ) | `v1.29.0` -> `v1.30.0` | [](https://docs.renovatebot.com/merge-confidence/ ) | [](https://docs.renovatebot.com/merge-confidence/ ) |
---
### Release Notes
<details>
<summary>forgejo/act (code.forgejo.org/forgejo/act)</summary>
### [`v1.30.0`](https://code.forgejo.org/forgejo/act/compare/v1.29.0...v1.30.0 )
[Compare Source](https://code.forgejo.org/forgejo/act/compare/v1.29.0...v1.30.0 )
</details>
---
### Configuration
📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4yMy4yIiwidXBkYXRlZEluVmVyIjoiNDEuMjMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/695
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Renovate Bot <bot@kriese.eu>
Co-committed-by: Renovate Bot <bot@kriese.eu>
2025-07-14 13:21:52 +00:00
Earl Warren
6620cc1d18
fix: allow overriding RUNNER_TOOL_CACHE from the config file ( #178 )
...
- rc.getToolCache(ctx) is used to figure out RUNNER_TOOL_CACHE and returns RUNNER_TOOL_CACHE if it is found in the runner config, e.g.
```yaml
container:
env:
RUNNER_TOOL_CACHE: /srv/toolcache
```
- store the value in the new `toolCache` data member for containers, in the same way it is done for host
- GetRunnerContext for containers return `toolCache` instead of a hard coded string
- add integration test
Closes forgejo/runner#184
Reviewed-on: https://code.forgejo.org/forgejo/act/pulls/178
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2025-07-13 21:55:02 +00:00
earl-warren
d2f668c880
fix!: fallback to sh if bash does not exist ( #177 )
...
Reviewed-on: https://code.forgejo.org/forgejo/act/pulls/177
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2025-07-13 15:59:34 +00:00
earl-warren
ff48b5b0f6
feat!: validate workflows with a schema ( #170 )
...
Reviewed-on: https://code.forgejo.org/forgejo/act/pulls/170
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2025-07-12 17:03:55 +00:00
Earl Warren
c1892b6398
fix!: fallback to sh if bash does not exist
...
It is a breaking change because it changes how the shell is
determined.
Before, if `jobs.<job_id>.container.image` is set and the shell is not
specified, it defaults to `sh` instead of `bash`.
After, regardless of `jobs.<job_id>.container.image`, if the shell is
not specified, it defaults to `bash` if available, otherwise it
defaults to `sh`.
Rework the shell integration tests:
- Remove container specific tests because the special behavior related
to shell being set differently when a container image is present is
removed
- Modify the defaults test case to verify the fallback logic
- Use container images from code.forgejo.org to escape rate limiting
in the CI
- Add the missing node test
- Use
container:
image: code.forgejo.org/oci/node:22-bookworm
instead of
container: code.forgejo.org/oci/node:22-bookworm
because it silently failed to run (with no exit code)
- Prefer `-z "${BASH}"` because `-z ${BASH+x}` reads obscure
Closes forgejo/runner#150
2025-07-12 19:01:14 +02:00
Earl Warren
6e59f129c1
chore(refactor): add common.RandName to keep name generation DRY
2025-07-12 18:54:17 +02:00
Earl Warren
73b26d318a
feat: expressions in env can use the env context, that works
2025-07-12 17:46:16 +02:00
Earl Warren
fc1240060e
chore(release-notes): explain how to validate existing workflows ( #693 )
...
Before migrating to v8.0.0 with schema validation, existing workflows can be verified to pass with `forgejo-runner exec`.
Refs forgejo/act#170
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/693
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2025-07-12 13:45:59 +00:00
Earl Warren
2a37f3f1c3
fix: secrets can be used in jobs.*.if expressions
2025-07-12 13:42:56 +02:00
Earl Warren
923033af13
chore(release-notes): bash fallback to sh if it is not available (take 2)
...
Document that it is a breaking change.
Refs forgejo/runner#150
2025-07-12 11:40:26 +02:00
Earl Warren
f0090d8ac7
fix!: default to node:22-bookworm instead of node:20-bullseye ( #686 )
...
Closes forgejo/runner#134
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/686
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2025-07-12 09:36:58 +00:00
Earl Warren
ec05ed930f
chore(release-notes): bash fallback to sh if it is not available ( #691 )
...
Refs forgejo/runner#150
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/691
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2025-07-12 09:32:10 +00:00
Renovate Bot
39d9bc5e5f
Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v1.64.8 ( #690 )
...
This PR contains the following updates:
| Package | Change | Age | Confidence |
|---|---|---|---|
| [github.com/golangci/golangci-lint/cmd/golangci-lint](https://github.com/golangci/golangci-lint ) | `v1.62.2` -> `v1.64.8` | [](https://docs.renovatebot.com/merge-confidence/ ) | [](https://docs.renovatebot.com/merge-confidence/ ) |
---
### Release Notes
<details>
<summary>golangci/golangci-lint (github.com/golangci/golangci-lint/cmd/golangci-lint)</summary>
### [`v1.64.8`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1648 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.64.7...v1.64.8 )
- Detects use of configuration files from golangci-lint v2
### [`v1.64.7`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1647 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.64.6...v1.64.7 )
1. Linters bug fixes
- `depguard`: from 2.2.0 to 2.2.1
- `dupl`: from [`3e9179a`](3e9179ac44
) to [`f665c8d`](f665c8d69b
)
- `gosec`: from 2.22.1 to 2.22.2
- `staticcheck`: from 0.6.0 to 0.6.1
2. Documentation
- Add GitLab documentation
### [`v1.64.6`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1646 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.64.5...v1.64.6 )
1. Linters bug fixes
- `asciicheck`: from 0.4.0 to 0.4.1
- `contextcheck`: from 1.1.5 to 1.1.6
- `errcheck`: from 1.8.0 to 1.9.0
- `exptostd`: from 0.4.1 to 0.4.2
- `ginkgolinter`: from 0.19.0 to 0.19.1
- `go-exhaustruct`: from 3.3.0 to 3.3.1
- `gocheckcompilerdirectives`: from 1.2.1 to 1.3.0
- `godot`: from 1.4.20 to 1.5.0
- `perfsprint`: from 0.8.1 to 0.8.2
- `revive`: from 1.6.1 to 1.7.0
- `tagalign`: from 1.4.1 to 1.4.2
### [`v1.64.5`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1645 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.64.4...v1.64.5 )
1. Bug fixes
- Add missing flag `new-from-merge-base-flag`
2. Linters bug fixes
- `asciicheck`: from 0.3.0 to 0.4.0
- `forcetypeassert`: from 0.1.0 to 0.2.0
- `gosec`: from 2.22.0 to 2.22.1
### [`v1.64.4`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1644 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.64.3...v1.64.4 )
1. Linters bug fixes
- `gci`: fix standard packages list for go1.24
### [`v1.64.3`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1643 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.64.2...v1.64.3 )
1. Linters bug fixes
- `ginkgolinter`: from 0.18.4 to 0.19.0
- `go-critic`: from 0.11.5 to 0.12.0
- `revive`: from 1.6.0 to 1.6.1
- `gci`: fix standard packages list for go1.24
2. Misc.
- Build Docker images with go1.24
### [`v1.64.2`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1642 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.64.1...v1.64.2 )
This is the last minor release of golangci-lint v1.
The next release will be golangci-lint [v2](https://github.com/golangci/golangci-lint/issues/5300 ).
1. Enhancements
- 🎉 go1.24 support
- New `issues.new-from-merge-base` option
- New `run.relative-path-mode` option
2. Linters new features
- `copyloopvar`: from 1.1.0 to 1.2.1 (support suggested fixes)
- `exptostd`: from 0.3.1 to 0.4.1 (handles `golang.org/x/exp/constraints.Ordered`)
- `fatcontext`: from 0.5.3 to 0.7.1 (new option: `check-struct-pointers`)
- `perfsprint`: from 0.7.1 to 0.8.1 (new options: `integer-format`, `error-format`, `string-format`, `bool-format`, and `hex-format`)
- `revive`: from 1.5.1 to 1.6.0 (new rules: `redundant-build-tag`, `use-errors-new`. New option `early-return.early-return`)
3. Linters bug fixes
- `go-errorlint`: from 1.7.0 to 1.7.1
- `gochecknoglobals`: from 0.2.1 to 0.2.2
- `godox`: from [`006bad1`](006bad1f9d
) to 1.1.0
- `gosec`: from 2.21.4 to 2.22.0
- `iface`: from 1.3.0 to 1.3.1
- `nilnesserr`: from 0.1.1 to 0.1.2
- `protogetter`: from 0.3.8 to 0.3.9
- `sloglint`: from 0.7.2 to 0.9.0
- `spancheck`: fix default `StartSpanMatchersSlice` values
- `staticcheck`: from 0.5.1 to 0.6.0
4. Deprecations
- ⚠️ `tenv` is deprecated and replaced by `usetesting.os-setenv: true`.
- ⚠️ `exportloopref` deprecation step 2
5. Misc.
- Sanitize severities by output format
- Avoid panic with plugin without description
6. Documentation
- Clarify `depguard` configuration
### [`v1.64.1`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1641 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.64.0...v1.64.1 )
Cancelled due to CI failure.
### [`v1.64.0`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1640 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.63.4...v1.64.0 )
Cancelled due to CI failure.
### [`v1.63.4`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1634 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.63.3...v1.63.4 )
1. Linters bug fixes
- `dupl`, `gomodguard`, `revive`: keep only Go-files.
### [`v1.63.3`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1633 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.63.2...v1.63.3 )
1. Linters bug fixes
- `gofmt`, `gofumpt`, `goimports`, `gci`: panic with several trailing EOL
- `goheader`: skip issues with invalid positions
### [`v1.63.2`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1632 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.63.1...v1.63.2 )
1. Linters bug fixes
- `gofmt`, `gofumpt`, `goimports`, `gci`: panic with missing trailing EOL
### [`v1.63.1`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1631 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.63.0...v1.63.1 )
1. Linters bug fixes
- `cgi`: invalid reports with cgo
- `gofumpt`: panic with autofix and cgo
### [`v1.63.0`](https://github.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1630 )
[Compare Source](https://github.com/golangci/golangci-lint/compare/v1.62.2...v1.63.0 )
1. Enhancements
- Add support for SuggestedFixes 🎉 (35 linters can "autofix" reports).
- Formatters (`gofmt`, `goimports`, `gofumpt`, `gci`) are applied after the suggested fixes.
2. New linters
- Add `exptostd` linter https://github.com/ldez/exptostd
- Add `nilnesserr` linter https://github.com/alingse/nilnesserr
- Add `usetesting` linter https://github.com/ldez/usetesting
3. Linters new features
- `gci`: new options: `no-inline-comments`, `no-prefix-comments`
- `gomoddirectives`: from 0.2.4 to 0.6.0 (new options: `go-version-pattern`, `toolchain-pattern`,`toolchain-forbidden`, `tool-forbidden`, `go-debug-forbidden`)
- `govet`: new `stdversion`, `waitgroup` analyzers
- `importas`: allow multiple empty aliases
- `loggercheck`: new `slog` option
- `recvcheck`: from 0.1.2 to 0.2.0 (new options: `disable-builtin`, `exclusions`)
- `tagliatelle`: from 0.5.0 to 0.7.1 (new options: `ignored-fields`, `extended-rules`,`overrides`, `pkg`, `ignore`)
- `usestdlibvars`: from 1.27.0 to 1.28.0 (autofix)
- `wrapcheck`: from 2.9.0 to 2.10.0 (new option: `extra-ignore-sigs`)
4. Linters bug fixes
- `asciicheck`: from 0.2.0 to 0.3.0
- `bodyclose`: from [`5742072`](5742072509
) to [`ed6a65f`](ed6a65f985
)
- `funlen`: from 0.1.0 to 0.2.0
- `ginkgolinter`: from 0.18.3 to 0.18.4
- `gochecksumtype`: from 0.2.0 to 0.3.1
- `gocognit`: from 1.1.3 to 1.2.0
- `godot`: from 1.4.18 to 1.4.20
- `goheader`: report position improvement
- `gosec`: handling of global nosec option when it is false
- `iface`: from 1.2.1 to 1.3.0
- `importas`: from 0.1.0 to 0.2.0
- `intrange`: from 0.2.1 to 0.3.0
- `makezero`: from 1.1.1 to 1.2.0
- `mirror`: from 1.2.0 to 1.3.0
- `nilnil`: from 1.0.0 to 1.0.1
- `nosprintfhostport`: from 0.1.1 to 0.2.0
- `reassign`: from 0.2.0 to 0.3.0
- `spancheck`: from 0.6.2 to 0.6.4
- `tagalign`: from 1.3.4 to 1.4.1
- `wastedassign`: from 2.0.7 to 2.1.0
- `whitespace`: from 0.1.1 to 0.2.0
- `wsl`: from 4.4.1 to 4.5.0
5. Deprecations
- ⚠️ `output.uniq-by-line` is deprecated and replaced by `issues.uniq-by-line`.
6. Misc.
- Improvements of the help command (color and JSON support).
- Removes `decoder`, `sloglint`, `tagalign` from `format` preset.
- Enables paths with junction inside Windows.
- The timeout is disabled if `run.timeout` <= 0.
</details>
---
### Configuration
📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4yMy4yIiwidXBkYXRlZEluVmVyIjoiNDEuMjMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/690
Reviewed-by: earl-warren <earl-warren@noreply.code.forgejo.org>
Co-authored-by: Renovate Bot <bot@kriese.eu>
Co-committed-by: Renovate Bot <bot@kriese.eu>
2025-07-12 07:52:16 +00:00
ChristopherHX
4b2eb56a54
feat: allow workflow description ( #5326 )
...
Otherwise act would reject such workflows right away
(cherry picked from commit efc95959aca96034426dcb93275eede5a3f47b83)
Conflicts:
pkg/schema/workflow_schema.json
trivial context conflict
2025-07-11 14:12:22 +02:00
Earl Warren
062e57b1c7
feat: the forge context is equivalent to the github context
2025-07-11 14:12:22 +02:00
Earl Warren
7ef85d2a14
feat: Forgejo has support for support services.<id>.cmd
2025-07-11 14:12:22 +02:00
Earl Warren
cbdb42093b
chore(tests): fix invalid jobparser tests
...
- has_with had undetected structure error now failing the schema
- empty_step and has_secrets are invalid and caught by the schema
there no longer is a need for them
2025-07-11 14:12:22 +02:00
Earl Warren
e069333f58
chore(docs): do not link to nektosact web page on validation error
...
The error messages however difficult to parse will have to stand
on their own.
2025-07-11 14:12:22 +02:00
Earl Warren
960b552ba9
feat: add enable-email-notifications to the schema
2025-07-11 14:12:22 +02:00
Earl Warren
5faf1bbc54
chore(tests): workflows are validated via a schema
...
This test was introduced by 61b7859f12
to verify a safeguard prevents a crash. With schema validation it is
caught at an earlier stage.
2025-07-11 14:12:22 +02:00
ChristopherHX
4453e1a834
fix: use non strict schema to allow some undefined behavior ( #2524 )
...
* fix: use non strict schema to allow some undefined behavior
* GitHub Actions doesn't use the newer strict schema in the service
* Tolerate more hallucinations
* Update workflow.go
* Update workflow.go
* Update pkg/model/workflow.go
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
---------
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit b52da6190c971733cdf3ffcef97cdbdce4ba42e5)
2025-07-11 14:12:22 +02:00
ChristopherHX
e489be545d
fix: schema validation for job if functions ( #2446 )
...
* fix: schema validation for job if functions
* Add Tests
* Update pkg/schema/schema.go
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* Update pkg/schema/schema.go
---------
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
(cherry picked from commit f043eb7079a16dfcf54d1f44fe66795ff76e973a)
2025-07-11 14:12:22 +02:00
ChristopherHX
65ae238f17
feat: Validate GitHub Actions schema ( #2416 )
...
* feat: Validate GitHub Actions schema
**BREAKING** previously accepted workflows are now invalid
* update code
* fix tests
* Bump docker / fix lint
* fix test action due to moving the file
* remove unused function
* fix parsing additional functions
* fix allow int
* update docker dep, due to linter
(cherry picked from commit 64219df0f2155d75ffc4423dc93c1e80bb4740bc)
Conflicts:
go.mod
go.sum
pkg/model/workflow.go
trivial context conflict & go.mod upgrades
2025-07-11 14:12:22 +02:00
Earl Warren
91be87f293
chore(lint): add lint to the CI and make it happy ( #685 )
...
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/685
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2025-07-11 07:57:23 +00:00
Earl Warren
5e3cb5468c
fix: use accessors on protobuf messages instead of struct members ( #684 )
...
So it does not panic if one is nil.
Closes forgejo/runner#146
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/684
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2025-07-11 07:10:41 +00:00
Renovate Bot
90a12ccd80
Update module golang.org/x/term to v0.33.0 ( #687 )
...
This PR contains the following updates:
| Package | Change | Age | Confidence |
|---|---|---|---|
| [golang.org/x/term](https://pkg.go.dev/golang.org/x/term ) | [`v0.32.0` -> `v0.33.0`](https://cs.opensource.google/go/x/term/+/refs/tags/v0.32.0...refs/tags/v0.33.0 ) | [](https://docs.renovatebot.com/merge-confidence/ ) | [](https://docs.renovatebot.com/merge-confidence/ ) |
---
### Configuration
📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4yMy4yIiwidXBkYXRlZEluVmVyIjoiNDEuMjMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/687
Co-authored-by: Renovate Bot <bot@kriese.eu>
Co-committed-by: Renovate Bot <bot@kriese.eu>
2025-07-11 05:43:08 +00:00
Earl Warren
01e4828ab6
chore: s/GITHUB_*/FORGEJO_*/ & s/github./forge./ ( #682 )
...
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/682
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2025-07-10 14:41:49 +00:00
Renovate Bot
f20ecb7460
Update module github.com/docker/docker to v28.3.2+incompatible ( #683 )
...
This PR contains the following updates:
| Package | Change | Age | Confidence |
|---|---|---|---|
| [github.com/docker/docker](https://github.com/docker/docker ) | `v28.3.0+incompatible` -> `v28.3.2+incompatible` | [](https://docs.renovatebot.com/merge-confidence/ ) | [](https://docs.renovatebot.com/merge-confidence/ ) |
---
### Release Notes
<details>
<summary>docker/docker (github.com/docker/docker)</summary>
### [`v28.3.2+incompatible`](https://github.com/docker/docker/compare/v28.3.1...v28.3.2 )
[Compare Source](https://github.com/docker/docker/compare/v28.3.1...v28.3.2 )
### [`v28.3.1+incompatible`](https://github.com/docker/docker/compare/v28.3.0...v28.3.1 )
[Compare Source](https://github.com/docker/docker/compare/v28.3.0...v28.3.1 )
</details>
---
### Configuration
📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4yMy4yIiwidXBkYXRlZEluVmVyIjoiNDEuMjMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/683
Reviewed-by: earl-warren <earl-warren@noreply.code.forgejo.org>
Co-authored-by: Renovate Bot <bot@kriese.eu>
Co-committed-by: Renovate Bot <bot@kriese.eu>
2025-07-10 08:58:32 +00:00
Renovate Bot
4d059468af
Update dependency go to v1.23.11 ( #681 )
...
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [go](https://go.dev/ ) ([source](https://github.com/golang/go )) | toolchain | patch | `1.23.10` -> `1.23.11` |
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4yMy4yIiwidXBkYXRlZEluVmVyIjoiNDEuMjMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/681
Reviewed-by: earl-warren <earl-warren@noreply.code.forgejo.org>
Co-authored-by: Renovate Bot <bot@kriese.eu>
Co-committed-by: Renovate Bot <bot@kriese.eu>
2025-07-09 08:09:38 +00:00
Earl Warren
d51f20b1db
chore: redirect new feature requests to a dedicated tracker (take 2)
...
Refs: https://codeberg.org/forgejo/discussions/issues/369
2025-07-08 16:26:20 +02:00
Earl Warren
c8edaf8368
chore: redirect new feature requests to a dedicated tracker
...
Refs: https://codeberg.org/forgejo/discussions/issues/369
2025-07-08 16:23:32 +02:00
Earl Warren
22a9c49672
fix: reporter.SetOutputs must ignore values that overflow the size ( #662 )
...
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/662
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2025-07-08 09:02:50 +00:00