oss/forgejo-runner
oss/forgejo-runner
1
0
Fork 0
mirror of https://code.forgejo.org/forgejo/runner.git synced 2025-08-06 17:40:58 +00:00
Code Wiki Activity

Fix: panic: reflect: slice index out of range (#1066)

Browse source 
* Fix: panic: reflect: slice index out of range

* Update interpreter.go

* [no ci] Return null for negative indexes

* Add tests for index access

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This commit is contained in:
ChristopherHX 2022-03-22 19:05:36 +01:00 • committed by GitHub
parent 75fd2e2883
commit f9514484e9
2 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
act/exprparser/interpreter_test.go
View file

@ -50,6 +50,10 @@ func TestOperators(t *testing.T) {
{"github.action[0]", nil, "string-index", "Unable to index on non-slice value: string"},
{"fromJSON('[0,1]')[1]", 1.0, "array-index", ""},
{"(github.event.commits.*.author.username)[0]", "someone", "array-index-0", ""},
{"fromJSON('[0,1]')[2]", nil, "array-index-out-of-bounds-0", ""},
{"fromJSON('[0,1]')[34553]", nil, "array-index-out-of-bounds-1", ""},
{"fromJSON('[0,1]')[-1]", nil, "array-index-out-of-bounds-2", ""},
{"fromJSON('[0,1]')[-34553]", nil, "array-index-out-of-bounds-3", ""},
{"!true", false, "not", ""},
{"1 < 2", true, "less-than", ""},
{`'b' <= 'a'`, false, "less-than-or-equal", ""},