From eb76c801934dc6961d87a982d0f2b90753ec52cb Mon Sep 17 00:00:00 2001 From: Earl Warren Date: Sun, 24 Mar 2024 11:56:42 +0100 Subject: [PATCH] [FORGEJO] a network of "" is not the same as "host" The comment that introduced this change suggests it was motivated by a border case by which the image would be empty. It is however unclear why it should have any impact on how the network name is determined. The hunk is reverted. https://github.com/nektos/act/pull/1949/files#r1315163582 --- act/runner/run_context.go | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/act/runner/run_context.go b/act/runner/run_context.go index 8aa004ca..06679cae 100644 --- a/act/runner/run_context.go +++ b/act/runner/run_context.go @@ -535,13 +535,6 @@ func (rc *RunContext) startJobContainer() common.Executor { return nil } - jobContainerNetwork := rc.Config.ContainerNetworkMode.NetworkName() - if rc.containerImage(ctx) != "" { - jobContainerNetwork = networkName - } else if jobContainerNetwork == "" { - jobContainerNetwork = "host" - } - rc.JobContainer = container.NewContainer(&container.NewContainerInput{ Cmd: nil, Entrypoint: []string{"tail", "-f", "/dev/null"}, @@ -552,7 +545,7 @@ func (rc *RunContext) startJobContainer() common.Executor { Name: name, Env: envList, Mounts: mounts, - NetworkMode: jobContainerNetwork, + NetworkMode: networkName, NetworkAliases: []string{rc.Name}, Binds: binds, Stdout: logWriter,