From e0facd1ee58ea4169f43f0566ff7c526fe59e692 Mon Sep 17 00:00:00 2001 From: Earl Warren Date: Wed, 22 Jan 2025 22:24:27 +0100 Subject: [PATCH] fix(tests): binds are not sorted That creates false negative in test runs. Just keep one, there is no value in having more. --- act/container/docker_run_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/act/container/docker_run_test.go b/act/container/docker_run_test.go index 6b47ef6f..7383864a 100644 --- a/act/container/docker_run_test.go +++ b/act/container/docker_run_test.go @@ -258,13 +258,13 @@ func TestMergeJobOptions(t *testing.T) { }{ { name: "ok", - options: "--volume /foo:/bar --volume /frob:/nitz --volume somevolume --tmpfs /tmp:exec,noatime --hostname alternatehost", + options: "--volume /frob:/nitz --volume somevolume --tmpfs /tmp:exec,noatime --hostname alternatehost", config: &container.Config{ Volumes: map[string]struct{}{"somevolume": {}}, Hostname: "alternatehost", }, hostConfig: &container.HostConfig{ - Binds: []string{"/foo:/bar", "/frob:/nitz"}, + Binds: []string{"/frob:/nitz"}, Tmpfs: map[string]string{"/tmp": "exec,noatime"}, }, },