oss/forgejo-runner
oss/forgejo-runner
1
0
Fork 0
mirror of https://code.forgejo.org/forgejo/runner.git synced 2025-08-21 18:11:06 +00:00
Code Wiki Activity

fix: composite action input pollution (#2348)

Browse source 
* fix: composite action input pollution

* fix run steps

* fix missing defaults in post after env cleanup

* fix test to make more sense

* Add tests and simplify change

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 54245641d28fc496152684e151043ce0c7389086)

Conflicts:
	act/runner/step_test.go
    the modified test does not exist in the Forgejo runner
This commit is contained in:
ChristopherHX 2024-06-05 16:44:44 +02:00 • committed by Earl Warren
parent a737f197c7
commit cb99c53dc1
No known key found for this signature in database
GPG key ID: 0579CB2928A78A00
15 changed files with 181 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
act/runner/step.go
View file

@ -262,6 +262,16 @@ func mergeEnv(ctx context.Context, step step) {
}
rc.withGithubEnv(ctx, step.getGithubContext(ctx), *env)
if step.getStepModel().Uses != "" {
// prevent uses action input pollution of unset parameters, skip this for run steps
// due to design flaw
for key := range *env {
if strings.Contains(key, "INPUT_") {
delete(*env, key)
}
}
}
}
func isStepEnabled(ctx context.Context, expr string, step step, stage stepStage) (bool, error) {