oss/forgejo-runner
oss/forgejo-runner
1
0
Fork 0
mirror of https://code.forgejo.org/forgejo/runner.git synced 2025-10-10 19:32:04 +00:00
Code Wiki Activity

chore: cache: move repo != cache.Repo in readCache

Browse source 
- it only is used after calling readCache
- add unit test

it reduces the number of testcase to be considered in handler
This commit is contained in:
Earl Warren 2025-09-05 15:00:38 +02:00
parent 6c4e705f97
commit c28a98082b
No known key found for this signature in database
GPG key ID: 0579CB2928A78A00
3 changed files with 63 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

8
act/artifactcache/caches.go
View file

@ -20,7 +20,7 @@ import (
type caches interface {
openDB() (*bolthold.Store, error)
validateMac(rundata RunData) (string, error)
readCache(id uint64) (*Cache, error)
readCache(id uint64, repo string) (*Cache, error)
useCache(id uint64) error
setgcAt(at time.Time)
gcCache()
@ -139,7 +139,7 @@ func insertCache(db *bolthold.Store, cache *Cache) error {
return nil
}
func (c *cachesImpl) readCache(id uint64) (*Cache, error) {
func (c *cachesImpl) readCache(id uint64, repo string) (*Cache, error) {
db, err := c.openDB()
if err != nil {
return nil, err
@ -149,6 +149,10 @@ func (c *cachesImpl) readCache(id uint64) (*Cache, error) {
if err := db.Get(id, cache); err != nil {
return nil, fmt.Errorf("readCache: Get(%v): %w", id, err)
}
if cache.Repo != repo {
return nil, fmt.Errorf("readCache: Get(%v): cache.Repo %s != repo %s", id, cache.Repo, repo)
}
return cache, nil
}