From a737f197c7ab07e0048934f9221bcc363fa97199 Mon Sep 17 00:00:00 2001
From: Mathieu Fenniak <mathieu@fenniak.net>
Date: Sun, 10 Aug 2025 12:03:50 +0000
Subject: [PATCH] test: fix failures caused by node24 usage in
 hello-world-javascript-action [skip cascade] (#830)

node24 support has been added to GitHub Actions runner (https://github.com/actions/runner/releases/tag/v2.327.1), after which hello-world-javascript-action was updated to node24 (https://github.com/actions/hello-world-javascript-action/commit/d5e3943272d5c849e9522f6fbb5465c349895172) causing test failures since forgejo-runner doesn't support `node24`.  To unblock test execution, this pins to the `v1` tag which was already done in two other tests anyway.

<!--start release-notes-assistant-->
<!--URL:https://code.forgejo.org/forgejo/runner-->
- other
  - [PR](https://code.forgejo.org/forgejo/runner/pulls/830): <!--number 830 --><!--line 0 --><!--description dGVzdDogZml4IGZhaWx1cmVzIGNhdXNlZCBieSBub2RlMjQgdXNhZ2UgaW4gaGVsbG8td29ybGQtamF2YXNjcmlwdC1hY3Rpb24gW3NraXAgY2FzY2FkZV0=-->test: fix failures caused by node24 usage in hello-world-javascript-action [skip cascade]<!--description-->
<!--end release-notes-assistant-->

Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/830
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net>
Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net>
---
 act/runner/testdata/issue-597/spelling.yaml |  2 +-
 act/runner/testdata/issue-598/spelling.yml  | 15 +++++++--------
 act/runner/testdata/parallel/push.yml       |  2 +-
 3 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/act/runner/testdata/issue-597/spelling.yaml b/act/runner/testdata/issue-597/spelling.yaml
index 469f1500..120e2c7a 100644
--- a/act/runner/testdata/issue-597/spelling.yaml
+++ b/act/runner/testdata/issue-597/spelling.yaml
@@ -15,7 +15,7 @@ jobs:
           fetch-depth: 5
       - name: My first true step
         if: ${{endsWith('Hello world', 'ld')}}
-        uses: https://github.com/actions/hello-world-javascript-action@main
+        uses: https://github.com/actions/hello-world-javascript-action@v1
         with:
           who-to-greet: "Renst the Octocat"
       - name: My second false step
diff --git a/act/runner/testdata/issue-598/spelling.yml b/act/runner/testdata/issue-598/spelling.yml
index 46dcc77f..ef741b22 100644
--- a/act/runner/testdata/issue-598/spelling.yml
+++ b/act/runner/testdata/issue-598/spelling.yml
@@ -1,31 +1,30 @@
 name: issue-598
 on: push
-  
+
 
 jobs:
   my_first_job:
-    
+
     runs-on: ubuntu-latest
     steps:
       - name: My first false step
         if: "endsWith('Hello world', 'o1')"
-        uses: https://github.com/actions/hello-world-javascript-action@main
+        uses: https://github.com/actions/hello-world-javascript-action@v1
         with:
           who-to-greet: 'Mona the Octocat'
       - name: My first true step
         if: "!endsWith('Hello world', 'od')"
-        uses: https://github.com/actions/hello-world-javascript-action@main
+        uses: https://github.com/actions/hello-world-javascript-action@v1
         with:
           who-to-greet: "Renst the Octocat"
       - name: My second false step
         if: "endsWith('Hello world', 'o2')"
-        uses: https://github.com/actions/hello-world-javascript-action@main
+        uses: https://github.com/actions/hello-world-javascript-action@v1
         with:
           who-to-greet: 'Act the Octocat'
       - name: My third false step
         if: "endsWith('Hello world', 'o2')"
-        uses: https://github.com/actions/hello-world-javascript-action@main
+        uses: https://github.com/actions/hello-world-javascript-action@v1
         with:
           who-to-greet: 'Git the Octocat'
-           
-           
\ No newline at end of file
+
diff --git a/act/runner/testdata/parallel/push.yml b/act/runner/testdata/parallel/push.yml
index 1af9165e..9eb420dc 100644
--- a/act/runner/testdata/parallel/push.yml
+++ b/act/runner/testdata/parallel/push.yml
@@ -9,7 +9,7 @@ jobs:
       - uses: ./actions/action1
         with:
           args: echo 'build'
-      - uses: https://github.com/actions/hello-world-javascript-action@master
+      - uses: https://github.com/actions/hello-world-javascript-action@v1
         with:
           who-to-greet: 'Mona the Octocat'
   test1: