From 78a021bc1440bbb3d0ea85f2b2cbdbf0f600cc1c Mon Sep 17 00:00:00 2001 From: ChristopherHX Date: Sun, 12 Nov 2023 19:09:25 +0100 Subject: [PATCH] fix: (#2075) network-scoped alias is supported only for containers in user defined networks Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> --- act/container/docker_run.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/act/container/docker_run.go b/act/container/docker_run.go index f5a898ee..5a8afa22 100644 --- a/act/container/docker_run.go +++ b/act/container/docker_run.go @@ -447,7 +447,9 @@ func (cr *containerReference) create(capAdd []string, capDrop []string) common.E var networkingConfig *network.NetworkingConfig logger.Debugf("input.NetworkAliases ==> %v", input.NetworkAliases) - if hostConfig.NetworkMode.IsUserDefined() && len(input.NetworkAliases) > 0 { + n := hostConfig.NetworkMode + // TODO: use IsUserDefined() once it's windows implementation matches the unix one + if !n.IsDefault() && !n.IsBridge() && !n.IsHost() && !n.IsNone() && !n.IsContainer() && len(input.NetworkAliases) > 0 { endpointConfig := &network.EndpointSettings{ Aliases: input.NetworkAliases, }