From 6245f71556178342f0163cd88d0a0070f1eabf53 Mon Sep 17 00:00:00 2001 From: Gusted Date: Sat, 24 May 2025 08:31:05 +0000 Subject: [PATCH] Remove unused header (#496) - Forgejo (since v8, https://codeberg.org/forgejo/forgejo/commit/38ea77ebbebaedd6f0df5312639e336b61bb655c) does not use the value of this header, it was [introduced in v1.20](https://codeberg.org/forgejo/forgejo/commit/371520d7ab5c018c380f8f7981a8be7d40a01f72). - Older forgejo version than v8 handle it gracefully if this value is not sent. Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/496 Reviewed-by: earl-warren Co-authored-by: Gusted Co-committed-by: Gusted --- internal/pkg/client/header.go | 2 -- internal/pkg/client/http.go | 4 ---- 2 files changed, 6 deletions(-) diff --git a/internal/pkg/client/header.go b/internal/pkg/client/header.go index 24844fa..ab29a55 100644 --- a/internal/pkg/client/header.go +++ b/internal/pkg/client/header.go @@ -6,6 +6,4 @@ package client const ( UUIDHeader = "x-runner-uuid" TokenHeader = "x-runner-token" - // Deprecated: could be removed after Gitea 1.20 released - VersionHeader = "x-runner-version" ) diff --git a/internal/pkg/client/http.go b/internal/pkg/client/http.go index 7f3ca26..193e329 100644 --- a/internal/pkg/client/http.go +++ b/internal/pkg/client/http.go @@ -40,10 +40,6 @@ func New(endpoint string, insecure bool, uuid, token, version string, opts ...co if token != "" { req.Header().Set(TokenHeader, token) } - // TODO: version will be removed from request header after Gitea 1.20 released. - if version != "" { - req.Header().Set(VersionHeader, version) - } return next(ctx, req) } })))