From 620f8528898c893af17d2ee1bcd7e0ed8c27e126 Mon Sep 17 00:00:00 2001 From: Ryan Fleet Date: Thu, 19 Jun 2025 17:37:15 -0400 Subject: [PATCH] added info log when container image platform mismatched (#3225) * added info log when container image platform mismatched * inline image architecture comparison into ImageExistsLocally function as per review request (cherry picked from commit 77d31c96a9486553908fdeb1c3053015238d5a0a) --- act/container/docker_images.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/act/container/docker_images.go b/act/container/docker_images.go index 484cc834..84dd5d12 100644 --- a/act/container/docker_images.go +++ b/act/container/docker_images.go @@ -8,6 +8,7 @@ import ( cerrdefs "github.com/containerd/errdefs" "github.com/docker/docker/api/types/image" + "github.com/nektos/act/pkg/common" ) // ImageExistsLocally returns a boolean indicating if an image with the @@ -26,10 +27,15 @@ func ImageExistsLocally(ctx context.Context, imageName, platform string) (bool, return false, err } - if platform == "" || platform == "any" || fmt.Sprintf("%s/%s", inspectImage.Os, inspectImage.Architecture) == platform { + imagePlatform := fmt.Sprintf("%s/%s", inspectImage.Os, inspectImage.Architecture) + + if platform == "" || platform == "any" || imagePlatform == platform { return true, nil } + logger := common.Logger(ctx) + logger.Infof("image found but platform does not match: %s (image) != %s (platform)\n", imagePlatform, platform) + return false, nil }