From 31626146c2e8950bcf0cd180d7eb4de3861a87d9 Mon Sep 17 00:00:00 2001 From: Earl Warren Date: Sat, 5 Jul 2025 22:05:25 +0000 Subject: [PATCH] chore(cleanup): remove tests that will be obsoleted (#664) and it is kind of useless anyway because invalid workflows are currently failing in very inconsistent and unpredictable ways. Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/664 Co-authored-by: Earl Warren Co-committed-by: Earl Warren --- internal/app/run/workflow_test.go | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/internal/app/run/workflow_test.go b/internal/app/run/workflow_test.go index 6f57c7d2..09db288a 100644 --- a/internal/app/run/workflow_test.go +++ b/internal/app/run/workflow_test.go @@ -62,24 +62,6 @@ jobs: want1: "job9", wantErr: false, }, - { - name: "valid YAML syntax in top level env but wrong value type", - args: args{ - task: &runnerv1.Task{ - WorkflowPayload: []byte(` -on: push - -env: - value: {{ }} -`), - }, - }, - assert: func(t *testing.T, wf *model.Workflow, err error) { - require.Nil(t, wf) - assert.ErrorContains(t, err, "cannot unmarshal") - }, - wantErr: true, - }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) {