From 2110aed6c7ac69d45c86ea6f3546118fe0b711b9 Mon Sep 17 00:00:00 2001 From: huajin tong <137764712+thirdkeyword@users.noreply.github.com> Date: Wed, 6 Mar 2024 22:20:06 +0800 Subject: [PATCH] fix function name in comment (#2240) Signed-off-by: thirdkeyword (cherry picked from commit 71ae39085eb9ed060ac55b45e55147489faaefa2) --- act/model/workflow.go | 4 ++-- act/runner/expression.go | 2 +- act/runner/logger.go | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/act/model/workflow.go b/act/model/workflow.go index eda6e089..465fdf1b 100644 --- a/act/model/workflow.go +++ b/act/model/workflow.go @@ -367,7 +367,7 @@ func environment(yml yaml.Node) map[string]string { return env } -// Environments returns string-based key=value map for a job +// Environment returns string-based key=value map for a job func (j *Job) Environment() map[string]string { return environment(j.Env) } @@ -604,7 +604,7 @@ func (s *Step) String() string { return s.ID } -// Environments returns string-based key=value map for a step +// Environment returns string-based key=value map for a step func (s *Step) Environment() map[string]string { return environment(s.Env) } diff --git a/act/runner/expression.go b/act/runner/expression.go index ae3f145c..ef89fceb 100644 --- a/act/runner/expression.go +++ b/act/runner/expression.go @@ -106,7 +106,7 @@ func (rc *RunContext) NewExpressionEvaluatorWithEnv(ctx context.Context, env map //go:embed hashfiles/index.js var hashfiles string -// NewExpressionEvaluator creates a new evaluator +// NewStepExpressionEvaluator creates a new evaluator func (rc *RunContext) NewStepExpressionEvaluator(ctx context.Context, step step) ExpressionEvaluator { // todo: cleanup EvaluationEnvironment creation job := rc.Run.Job() diff --git a/act/runner/logger.go b/act/runner/logger.go index 68902931..ef93a02b 100644 --- a/act/runner/logger.go +++ b/act/runner/logger.go @@ -52,7 +52,7 @@ func Masks(ctx context.Context) *[]string { return &[]string{} } -// WithLogger adds a value to the context for the logger +// WithMasks adds a value to the context for the logger func WithMasks(ctx context.Context, masks *[]string) context.Context { return context.WithValue(ctx, masksContextKeyVal, masks) }