oss/forgejo-runner
oss/forgejo-runner
1
0
Fork 0
mirror of https://code.forgejo.org/forgejo/runner.git synced 2025-09-15 18:57:01 +00:00
Code Wiki Activity

return 403 instead of 500 when not authorized correctly

Browse source
This commit is contained in:
Kwonunn 2025-01-13 16:59:07 +01:00 • committed by Kwonunn
parent e3adb49c50
commit 11062e4d6a
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
act/artifactcache/handler.go
View file

@ -163,7 +163,7 @@ func (h *Handler) find(w http.ResponseWriter, r *http.Request, params httprouter
rundata := runDataFromHeaders(r) rundata := runDataFromHeaders(r)
repo, err := h.validateMac(rundata) repo, err := h.validateMac(rundata)
if err != nil { if err != nil {
h.responseJSON(w, r, 500, err) h.responseJSON(w, r, 403, err)
return return
} }
@ -212,7 +212,7 @@ func (h *Handler) reserve(w http.ResponseWriter, r *http.Request, params httprou
rundata := runDataFromHeaders(r) rundata := runDataFromHeaders(r)
repo, err := h.validateMac(rundata) repo, err := h.validateMac(rundata)
if err != nil { if err != nil {
h.responseJSON(w, r, 500, err) h.responseJSON(w, r, 403, err)
return return
} }
@ -250,7 +250,7 @@ func (h *Handler) upload(w http.ResponseWriter, r *http.Request, params httprout
rundata := runDataFromHeaders(r) rundata := runDataFromHeaders(r)
repo, err := h.validateMac(rundata) repo, err := h.validateMac(rundata)
if err != nil { if err != nil {
h.responseJSON(w, r, 500, err) h.responseJSON(w, r, 403, err)
return return
} }
@ -304,7 +304,7 @@ func (h *Handler) commit(w http.ResponseWriter, r *http.Request, params httprout
rundata := runDataFromHeaders(r) rundata := runDataFromHeaders(r)
repo, err := h.validateMac(rundata) repo, err := h.validateMac(rundata)
if err != nil { if err != nil {
h.responseJSON(w, r, 500, err) h.responseJSON(w, r, 403, err)
return return
} }
@ -372,7 +372,7 @@ func (h *Handler) get(w http.ResponseWriter, r *http.Request, params httprouter.
rundata := runDataFromHeaders(r) rundata := runDataFromHeaders(r)
repo, err := h.validateMac(rundata) repo, err := h.validateMac(rundata)
if err != nil { if err != nil {
h.responseJSON(w, r, 500, err) h.responseJSON(w, r, 403, err)
return return
} }
@ -413,7 +413,7 @@ func (h *Handler) clean(w http.ResponseWriter, r *http.Request, params httproute
rundata := runDataFromHeaders(r) rundata := runDataFromHeaders(r)
_, err := h.validateMac(rundata) _, err := h.validateMac(rundata)
if err != nil { if err != nil {
h.responseJSON(w, r, 500, err) h.responseJSON(w, r, 403, err)
return return
} }
// TODO: don't support force deleting cache entries // TODO: don't support force deleting cache entries