1
0
Fork 0
mirror of https://code.forgejo.org/forgejo/runner.git synced 2025-09-15 18:57:01 +00:00

fix: rework setupShellCommand (#930)

* fix: rework `setupShellCommand`

* move all logic to separate function so we can test that later
* split `step.Shell` and `step.WorkingDirectory` setup into own funcs
* general cleanup of function
* use `ActPath` to not collide with checked out repository
* use `shellquote.Split()` instead of `strings.Fields()` for better command split
* replace single string concat with `fmt`

Signed-off-by: hackercat <me@hackerc.at>

* lint(editorconfig): ignore *_test.go due to mixed style

Signed-off-by: hackercat <me@hackerc.at>
This commit is contained in:
Ryan 2021-12-22 07:37:16 +01:00 committed by GitHub
parent 665bd249ea
commit 06ef9ae6fe
8 changed files with 167 additions and 82 deletions

View file

@ -1,9 +1,11 @@
on: push
env:
MY_SHELL: bash
jobs:
check:
runs-on: ubuntu-latest
steps:
- shell: bash
- shell: ${{ env.MY_SHELL }}
run: |
if [[ -n "$BASH" ]]; then
echo "I'm $BASH!"
@ -14,10 +16,22 @@ jobs:
runs-on: ubuntu-latest
container: node:12-buster-slim
steps:
- shell: bash
- shell: ${{ env.MY_SHELL }}
run: |
if [[ -n "$BASH" ]]; then
echo "I'm $BASH!"
else
exit 1
fi
check-job-default:
runs-on: ubuntu-latest
defaults:
run:
shell: ${{ env.MY_SHELL }}
steps:
- run: |
if [[ -n "$BASH" ]]; then
echo "I'm $BASH!"
else
exit 1
fi