From 59796325f6b2517d6024c86277bb1290fe365241 Mon Sep 17 00:00:00 2001 From: Zach Kirsch Date: Fri, 20 Jun 2025 13:04:56 -0400 Subject: [PATCH] Fix broken link on adr-fact-modules.md --- docs/adr/adr-fact-modules.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/adr/adr-fact-modules.md b/docs/adr/adr-fact-modules.md index 884526b..7b14dcc 100644 --- a/docs/adr/adr-fact-modules.md +++ b/docs/adr/adr-fact-modules.md @@ -27,7 +27,7 @@ These are a few examples of where bugs in some sections have manifested in stran ### Testing for completeness -We have [completeness tests](../direct-file/df-client/df-client-app/src/test/functionalFlowTests/checkFlowSetsFacts.ts) that can test that a section of the flow will leave certain facts as complete. However, it's unclear which facts we should test for completeness at which points because there are no well defined boundaries between sections. For instance, in example (1) above a test that `/filersCouldntBeDependents` was complete by the end of the spouse section would have prevented the bug, but nobody knew to write that test. +We have [completeness tests](../../direct-file/df-client/df-client-app/src/test/completenessTests/checkFlowSetsFacts.ts) that can test that a section of the flow will leave certain facts as complete. However, it's unclear which facts we should test for completeness at which points because there are no well defined boundaries between sections. For instance, in example (1) above a test that `/filersCouldntBeDependents` was complete by the end of the spouse section would have prevented the bug, but nobody knew to write that test. Beyond that, even if we get this right at some point, there's no guarantee it will remain correct, or that developers writing downstream tests will always respect a `/maybeCompleteFact` that gets a default value in derived fact `/alwaysCompleteFact`, there's no guarantee that a downstream fact will correctly use `/alwaysCompleteFact` instead of accidentally using the maybe complete version. @@ -123,4 +123,4 @@ But most of the above will be a lot easier if we understand the boundaries we ca 1. (12/4/23) Modified the term "namespace" to "module" 2. (12/4/23) Specified file name as module names 3. (12/4/23) Defaulted facts private to their module -4. (12/4/23) Specified how modules will be imported by Dependency blocks \ No newline at end of file +4. (12/4/23) Specified how modules will be imported by Dependency blocks