From 0b5e93eeffebe896401dd640014dfa816bfe09be Mon Sep 17 00:00:00 2001
From: AndSDev <AndSDev@gmail.com>
Date: Fri, 6 Jun 2025 10:34:02 +0300
Subject: [PATCH] fix(service/media): create directory for media file only on
 new file creation

Any access to a media file created a directory for it, which led to unnecessary operations. Especially if this media file had already been deleted (as well as its directory).
---
 src/service/globals/mod.rs | 3 ---
 src/service/media/mod.rs   | 5 +++++
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/service/globals/mod.rs b/src/service/globals/mod.rs
index 0ab3a936..45def51a 100644
--- a/src/service/globals/mod.rs
+++ b/src/service/globals/mod.rs
@@ -499,9 +499,6 @@ impl Service {
                 r.push(current_path);
             }
 
-            // Create all directories leading up to file
-            fs::create_dir_all(&r).inspect_err(|e| error!("Error creating leading directories for media with sha256 hash of {sha256_hex}: {e}"))?;
-
             r.push(filename);
         } else {
             r.push(sha256_hex);
diff --git a/src/service/media/mod.rs b/src/service/media/mod.rs
index dce07405..8e0e199f 100644
--- a/src/service/media/mod.rs
+++ b/src/service/media/mod.rs
@@ -660,6 +660,11 @@ pub async fn create_file(sha256_hex: &str, file: &[u8]) -> Result<()> {
                 .globals
                 .get_media_path(path, directory_structure, sha256_hex)?;
 
+            // Create all directories leading up to file
+            if let Some(parent) = path.parent() {
+                fs::create_dir_all(&parent).inspect_err(|e| error!("Error creating leading directories for media with sha256 hash of {sha256_hex}: {e}"))?;
+            }
+
             let mut f = File::create(path).await?;
             f.write_all(file).await?;
         }